Changeset 49192

Timestamp:

10/18/2020 05:16:33 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use self when appropriate.

• WP_List_Table::get_default_primary_column_name() is a protected method, so calling it statically with the class name is bad practice.
• Similarly, this applies when calling a private constructor in WP_Screen::get().

Props jrf.
See #50767.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-list-table.php (modified) (1 diff)
• class-wp-screen.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -1074 +1074 @@
         // fall back to the first non-checkbox column.
         if ( ! isset( $columns[ $default ] ) ) {
-            $default = WP_List_Table::get_default_primary_column_name();
+            $default = self::get_default_primary_column_name();
         }
 

trunk/src/wp-admin/includes/class-wp-screen.php

@@ -378 +378 @@
             }
         } else {
-            $screen     = new WP_Screen();
+            $screen     = new self();
             $screen->id = $id;
         }