Changeset 49202

Timestamp:

10/19/2020 01:34:03 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Embeds: Only catch clicks from the primary mouse button in the click handler, without any modifier keys.

This ensures that Ctrl/Cmd + click to open a link in the embed iframe in a new tab works as expected.

Props timhavinga, garrett-eclipse, smerriman, swissspidy, johnbillion, Mte90, iandunn, azaozz, afercia, audrasjb, SergeyBiryukov.
Fixes #39097.

File:

• trunk/src/js/_enqueues/lib/embed-template.js (modified) (2 diffs)

trunk/src/js/_enqueues/lib/embed-template.js

@@ -138 +138 @@
         }
 
-        /**
-         * Send this document's height to the parent (embedding) site.
-         */
+        // Send this document's height to the parent (embedding) site.
         sendEmbedMessage( 'height', Math.ceil( document.body.getBoundingClientRect().height ) );
 
@@ -162 +160 @@
             }
 
-            /**
-             * Send link target to the parent (embedding) site.
-             */
+            // Only catch clicks from the primary mouse button, without any modifiers.
+            if ( event.altKey || event.ctrlKey || event.metaKey || event.shiftKey ) {
+                return;
+            }
+
+            // Send link target to the parent (embedding) site.
             if ( href ) {
                 sendEmbedMessage( 'link', href );