Changeset 49211

Timestamp:

10/19/2020 09:14:06 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Pings/Trackbacks: Split do_all_pings() into several functions:

• do_all_pingbacks()
• do_all_enclosures()
• do_all_trackbacks()

This allows for the specific removal/replacement of one of more services.

Props dshanske, garrett-eclipse, Mista-Flo, azaozz, hellofromTonya.
Fixes #36576.

Location:

trunk/src/wp-includes

Files:

• comment.php (modified) (4 diffs)
• default-filters.php (modified) (1 diff)

trunk/src/wp-includes/comment.php

@@ -2801 +2801 @@
  *
  * @since 2.1.0
- *
- * @global wpdb $wpdb WordPress database abstraction object.
+ * @since 5.6.0 Introduced `do_all_pings` action hook for individual services.
  */
 function do_all_pings() {
-    global $wpdb;
-
-    // Do pingbacks.
+    /**
+     * Fires immediately after the `do_pings` event to hook services individually.
+     *
+     * @since 5.6.0
+     */
+    do_action( 'do_all_pings' );
+}
+
+/**
+ * Perform all pingbacks.
+ *
+ * @since 5.6.0
+ */
+function do_all_pingbacks() {
     $pings = get_posts(
         array(
@@ -2822 +2832 @@
         pingback( null, $ping );
     }
-
-    // Do enclosures.
+}
+
+/**
+ * Perform all enclosures.
+ *
+ * @since 5.6.0
+ */
+function do_all_enclosures() {
     $enclosures = get_posts(
         array(
@@ -2838 +2854 @@
         do_enclose( null, $enclosure );
     }
-
-    // Do trackbacks.
+}
+
+/**
+ * Perform all trackbacks.
+ *
+ * @since 5.6.0
+ */
+function do_all_trackbacks() {
     $trackbacks = get_posts(
         array(
@@ -2854 +2876 @@
         do_trackbacks( $trackback );
     }
-
-    // Do Update Services/Generic Pings.
-    generic_ping();
 }
 

trunk/src/wp-includes/default-filters.php

@@ -343 +343 @@
 add_action( 'do_feed_atom', 'do_feed_atom', 10, 1 );
 add_action( 'do_pings', 'do_all_pings', 10, 0 );
+add_action( 'do_all_pings', 'do_all_pingbacks', 10, 0 );
+add_action( 'do_all_pings', 'do_all_enclosures', 10, 0 );
+add_action( 'do_all_pings', 'do_all_trackbacks', 10, 0 );
+add_action( 'do_all_pings', 'generic_ping', 10, 0 );
 add_action( 'do_robots', 'do_robots' );
 add_action( 'do_favicon', 'do_favicon' );