Changeset 49214

Timestamp:

10/19/2020 10:43:21 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Themes: Add a return value to set_theme_mod() to allow for error handling.

Props latifi, hareesh-pillai.
Fixes #51296.

File:

• trunk/src/wp-includes/theme.php (modified) (4 diffs)

trunk/src/wp-includes/theme.php

@@ -1039 +1039 @@
  *
  * @since 2.1.0
+ * @since 5.6.0 A return value was added.
  *
  * @param string $name  Theme modification name.
  * @param mixed  $value Theme modification value.
+ * @return bool True if the value was updated, false otherwise.
  */
 function set_theme_mod( $name, $value ) {
@@ -1062 +1064 @@
 
     $theme = get_option( 'stylesheet' );
-    update_option( "theme_mods_$theme", $mods );
+
+    return update_option( "theme_mods_$theme", $mods );
 }
 
@@ -1088 +1091 @@
         return;
     }
+
     $theme = get_option( 'stylesheet' );
+
     update_option( "theme_mods_$theme", $mods );
 }
@@ -1105 +1110 @@
         $theme_name = wp_get_theme()->get( 'Name' );
     }
+
     delete_option( 'mods_' . $theme_name );
 }