Changeset 49230 for trunk/tests/phpunit/tests/image/editorImagick.php

Timestamp:

10/20/2020 02:35:10 PM (4 years ago)

Author:

mikeschroder

Message:

Media: Support Stream Wrappers In WP_Image_Editor_Imagick

Since WP_Image_Editor's introduction, stream wrappers have functioned in WP_Image_Editor_GD, but haven't been properly supported in WP_Image_Editor_Imagick.

• Detects stream wrappers and uses file_put_contents() along with Imagick::read/getImageBlob() for handling when necessary.
• Introduces private method, WP_Image_Editor_Imagick::write_image to handle detection and proper saving.
• Introduces WP_Test_Stream class for testing stream wrappers, along with new tests for Imagick's stream handling and a stream filename test.

Adds requirement for Imagick::readImageBlob(), available in Imagick >= 2.0.0, which aligns with the current requirement of Imagick >= 2.2.0.

Props p00ya, calin, joemcgill, pputzer, jimyaghi, mikeschroder.
Fixes #42663.

File:

• trunk/tests/phpunit/tests/image/editorImagick.php (modified) (2 diffs)

trunk/tests/phpunit/tests/image/editorImagick.php

@@ -17 +17 @@
         require_once ABSPATH . WPINC . '/class-wp-image-editor.php';
         require_once ABSPATH . WPINC . '/class-wp-image-editor-imagick.php';
+        require_once DIR_TESTROOT . '/includes/class-wp-test-stream.php';
 
         parent::setUp();
@@ -575 +576 @@
     }
 
+    /**
+     * Test that images can be loaded and written over streams
+     */
+    public function test_streams() {
+        stream_wrapper_register( 'wptest', 'WP_Test_Stream' );
+        WP_Test_Stream::$data = array(
+            'Tests_Image_Editor_Imagick' => array(
+                '/read.jpg' => file_get_contents( DIR_TESTDATA . '/images/waffles.jpg' ),
+            ),
+        );
+
+        $file                 = 'wptest://Tests_Image_Editor_Imagick/read.jpg';
+        $imagick_image_editor = new WP_Image_Editor_Imagick( $file );
+
+        $ret = $imagick_image_editor->load();
+        $this->assertNotWPError( $ret );
+
+        $temp_file = 'wptest://Tests_Image_Editor_Imagick/write.jpg';
+
+        $ret = $imagick_image_editor->save( $temp_file );
+        $this->assertNotWPError( $ret );
+
+        $this->assertSame( $temp_file, $ret['path'] );
+
+        if ( $temp_file !== $ret['path'] ) {
+            unlink( $ret['path'] );
+        }
+        unlink( $temp_file );
+    }
 }