Changeset 49237

Timestamp:

10/20/2020 04:21:12 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Introduce the WP_Site_Health::is_development_environment() method.

This allows Site Health tests to check if the current environment type is set to development or local.

Use the new method:

• In HTTPS tests, instead of a hardcoded check for localhost.
• In WP_DEBUG and WP_DEBUG_DISPLAY tests, to set the status to recommended instead of critical.

Props dkotter, Clorith, DavidAnderson, joyously, knutsp, afragen, SergeyBiryukov.
Fixes #47058.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -107 +107 @@
             $tests = WP_Site_Health::get_tests();
 
-            // Don't run https test on localhost.
-            if ( 'localhost' === preg_replace( '|https?://|', '', get_site_url() ) ) {
+            // Don't run https test on development environments.
+            if ( $this->is_development_environment() ) {
                 unset( $tests['direct']['https_status'] );
             }
@@ -1465 +1465 @@
 
                 $result['status'] = 'critical';
+
+                // On development environments, set the status to recommended.
+                if ( $this->is_development_environment() ) {
+                    $result['status'] = 'recommended';
+                }
 
                 $result['description'] .= sprintf(
@@ -2532 +2537 @@
         );
 
-        // Don't run https test on localhost.
-        if ( 'localhost' === preg_replace( '|https?://|', '', get_site_url() ) ) {
+        // Don't run https test on development environments.
+        if ( $this->is_development_environment() ) {
             unset( $tests['direct']['https_status'] );
         }
@@ -2616 +2621 @@
         set_transient( 'health-check-site-status-result', wp_json_encode( $site_status ) );
     }
+
+    /**
+     * Checks if the current environment type is set to 'development' or 'local'.
+     *
+     * @since 5.6.0
+     *
+     * @return bool True if it is a development environment, false if not.
+     */
+    public function is_development_environment() {
+        return in_array( wp_get_environment_type(), array( 'development', 'local' ), true );
+    }
+
 }