Changeset 49248 for trunk/src/wp-admin/user-edit.php

Timestamp:

10/20/2020 06:24:40 PM (4 years ago)

Author:

adamsilverstein

Message:

Users: improve password generation feature.

On the user edit screen improve handling and clarify language: rename the "Generate Password" and "Show password" buttons to "Set New Password". Clicking it always generates a password. Also: improve inline code comments and descriptions.

Props afercia, bookdude13, michaelarestad, pento.
Fixes #42852.

File:

• trunk/src/wp-admin/user-edit.php (modified) (4 diffs)

trunk/src/wp-admin/user-edit.php

@@ -633 +633 @@
     <td>
         <input class="hidden" value=" " /><!-- #24364 workaround -->
-        <button type="button" class="button wp-generate-pw hide-if-no-js"><?php _e( 'Generate Password' ); ?></button>
+        <button type="button" class="button wp-generate-pw hide-if-no-js" aria-expanded="false"><?php _e( 'Set New Password' ); ?></button>
         <div class="wp-pwd hide-if-js">
             <span class="password-input-wrapper">
@@ -642 +642 @@
                 <span class="text"><?php _e( 'Hide' ); ?></span>
             </button>
-            <button type="button" class="button wp-cancel-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Cancel password change' ); ?>">
+            <button type="button" class="button wp-cancel-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Cancel' ); ?>">
                 <span class="dashicons dashicons-no" aria-hidden="true"></span>
                 <span class="text"><?php _e( 'Cancel' ); ?></span>
@@ -653 +653 @@
     <th scope="row"><label for="pass2"><?php _e( 'Repeat New Password' ); ?></label></th>
     <td>
-    <input name="pass2" type="password" id="pass2" class="regular-text" value="" autocomplete="off" />
-    <p class="description"><?php _e( 'Type your new password again.' ); ?></p>
+    <input name="pass2" type="password" id="pass2" class="regular-text" value="" autocomplete="off" aria-describedby="pass2-desc" />
+    <?php if ( IS_PROFILE_PAGE ) : ?>
+        <p class="description" id="pass2-desc"><?php _e( 'Type your new password again.' ); ?></p>
+    <?php else : ?>
+        <p class="description" id="pass2-desc"><?php _e( 'Type the new password again.' ); ?></p>
+    <?php endif; ?>
     </td>
 </tr>
@@ -662 +666 @@
         <label>
             <input type="checkbox" name="pw_weak" class="pw-checkbox" />
-            <span id="pw-weak-text-label"><?php _e( 'Confirm use of potentially weak password' ); ?></span>
+            <span id="pw-weak-text-label"><?php _e( 'Confirm use of weak password' ); ?></span>
         </label>
     </td>