Changeset 49248 for trunk/src/wp-admin/user-new.php

Timestamp:

10/20/2020 06:24:40 PM (4 years ago)

Author:

adamsilverstein

Message:

Users: improve password generation feature.

On the user edit screen improve handling and clarify language: rename the "Generate Password" and "Show password" buttons to "Set New Password". Clicking it always generates a password. Also: improve inline code comments and descriptions.

Props afercia, bookdude13, michaelarestad, pento.
Fixes #42852.

File:

• trunk/src/wp-admin/user-new.php (modified) (3 diffs)

trunk/src/wp-admin/user-new.php

@@ -561 +561 @@
         <td>
             <input class="hidden" value=" " /><!-- #24364 workaround -->
-            <button type="button" class="button wp-generate-pw hide-if-no-js"><?php _e( 'Show password' ); ?></button>
-            <div class="wp-pwd hide-if-js">
+            <button type="button" class="button wp-generate-pw hide-if-no-js"><?php _e( 'Generate password' ); ?></button>
+            <div class="wp-pwd">
                 <?php $initial_password = wp_generate_password( 24 ); ?>
                 <span class="password-input-wrapper">
@@ -571 +571 @@
                     <span class="text"><?php _e( 'Hide' ); ?></span>
                 </button>
-                <button type="button" class="button wp-cancel-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Cancel password change' ); ?>">
-                    <span class="dashicons dashicons-no" aria-hidden="true"></span>
-                    <span class="text"><?php _e( 'Cancel' ); ?></span>
-                </button>
                 <div style="display:none" id="pass-strength-result" aria-live="polite"></div>
             </div>
@@ -582 +578 @@
         <th scope="row"><label for="pass2"><?php _e( 'Repeat Password' ); ?> <span class="description"><?php _e( '(required)' ); ?></span></label></th>
         <td>
-        <input name="pass2" type="password" id="pass2" autocomplete="off" />
+        <input name="pass2" type="password" id="pass2" autocomplete="off" aria-describedby="pass2-desc" />
+        <p class="description" id="pass2-desc"><?php _e( 'Type the password again.' ); ?></p>
         </td>
     </tr>