Changeset 49276 for trunk/src/wp-admin/authorize-application.php

Timestamp:

10/22/2020 03:04:23 PM (4 years ago)

Author:

TimothyBlynJacobs

Message:

App Passwords: Support an app_id to uniquely identify instances of an app.

Apps may now optionally include an app_id parameter when directing the user to the Authorize Application screen. This allows for instances of an application to be identified and potentially revoked or blocked.

Props TimothyBlynJacobs, georgestephanis.
Fixes #51583.

File:

• trunk/src/wp-admin/authorize-application.php (modified) (5 diffs)

trunk/src/wp-admin/authorize-application.php

@@ -19 +19 @@
     $reject_url  = $_POST['reject_url'];
     $app_name    = $_POST['app_name'];
+    $app_id      = $_POST['app_id'];
     $redirect    = '';
 
@@ -28 +29 @@
         }
     } elseif ( isset( $_POST['approve'] ) ) {
-        $created = WP_Application_Passwords::create_new_application_password( get_current_user_id(), array( 'name' => $app_name ) );
+        $created = WP_Application_Passwords::create_new_application_password(
+            get_current_user_id(),
+            array(
+                'name'   => $app_name,
+                'app_id' => $app_id,
+            )
+        );
 
         if ( is_wp_error( $created ) ) {
@@ -57 +64 @@
 
 $app_name    = ! empty( $_REQUEST['app_name'] ) ? $_REQUEST['app_name'] : '';
+$app_id      = ! empty( $_REQUEST['app_id'] ) ? $_REQUEST['app_id'] : '';
 $success_url = ! empty( $_REQUEST['success_url'] ) ? $_REQUEST['success_url'] : null;
 
@@ -69 +77 @@
 $user = wp_get_current_user();
 
-$request  = compact( 'app_name', 'success_url', 'reject_url' );
+$request  = compact( 'app_name', 'app_id', 'success_url', 'reject_url' );
 $is_valid = wp_is_authorize_application_password_request_valid( $request, $user );
 
@@ -184 +192 @@
                 <?php wp_nonce_field( 'authorize_application_password' ); ?>
                 <input type="hidden" name="action" value="authorize_application_password" />
+                <input type="hidden" name="app_id" value="<?php echo esc_attr( $app_id ); ?>" />
                 <input type="hidden" name="success_url" value="<?php echo esc_url( $success_url ); ?>" />
                 <input type="hidden" name="reject_url" value="<?php echo esc_url( $reject_url ); ?>" />