Changeset 49283 for trunk/src/wp-admin/includes/nav-menu.php

Timestamp:

10/23/2020 03:03:37 PM (5 years ago)

Author:

helen

Message:

Administration: Better targeting for required form field highlighting.

Previously, any input or select inside of a .form-invalid wrapper would get the red border highlighting, including submit buttons which was not visually correct. This now only applies to form elements with a class of .form-required inside of the .form-invalid wrapper. It also continues to apply the border to elements with both classes (.form-invalid.form-required) as that is how some of the admin markup is structured.

Plugin authors may need to do the same sort of class application seen in this commit, i.e. add .form-required to certain form elements.

Props sabernhardt, dilipbheda, helen.
Fixes #50686.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (1 diff)

trunk/src/wp-admin/includes/nav-menu.php

@@ -300 +300 @@
         <p id="menu-item-url-wrap" class="wp-clearfix">
             <label class="howto" for="custom-menu-item-url"><?php _e( 'URL' ); ?></label>
-            <input id="custom-menu-item-url" name="menu-item[<?php echo $_nav_menu_placeholder; ?>][menu-item-url]" type="text"<?php wp_nav_menu_disabled_check( $nav_menu_selected_id ); ?> class="code menu-item-textbox" placeholder="https://" />
+            <input id="custom-menu-item-url" name="menu-item[<?php echo $_nav_menu_placeholder; ?>][menu-item-url]" type="text"<?php wp_nav_menu_disabled_check( $nav_menu_selected_id ); ?> class="code menu-item-textbox form-required" placeholder="https://" />
         </p>