Changeset 49284

Timestamp:

10/23/2020 03:59:34 PM (6 years ago)

Author:

helen

Message:

Administration: Unify search results message on list tables.

This wraps the search string in a <strong> tag, which makes easier to parse visually especially when your search string also contains double quotes.

Props Mista-Flo, mapk, sergeybiryukov.
Fixes #37353.

Location:

trunk/src

Files:

• js/_enqueues/wp/updates.js (modified) (1 diff)
• wp-admin/edit-comments.php (modified) (1 diff)
• wp-admin/edit-tags.php (modified) (1 diff)
• wp-admin/edit.php (modified) (1 diff)
• wp-admin/includes/class-wp-plugins-list-table.php (modified) (1 diff)
• wp-admin/link-manager.php (modified) (1 diff)
• wp-admin/network/sites.php (modified) (1 diff)
• wp-admin/network/themes.php (modified) (1 diff)
• wp-admin/network/users.php (modified) (1 diff)
• wp-admin/plugins.php (modified) (1 diff)
• wp-admin/upload.php (modified) (1 diff)
• wp-admin/users.php (modified) (1 diff)

trunk/src/js/_enqueues/wp/updates.js

@@ -2581 +2581 @@
                                         sprintf(
                                                 /* translators: %s: Search query. */
-                                                __( 'Search results for “%s”' ),
-                                                _.escape( data.s )
+                                                __( 'Search results for: %s' ),
+                                                '<strong>' + _.escape( data.s ) + '</strong>'
                                         ) ),
                                         $oldSubTitle = $( '.wrap .subtitle' );

trunk/src/wp-admin/edit-comments.php

@@ -233 +233 @@
         printf(
                 /* translators: %s: Search query. */
-                __( 'Search results for “%s”' ),
-                wp_html_excerpt( esc_html( wp_unslash( $_REQUEST['s'] ) ), 50, '…' )
+                __( 'Search results for: %s' ),
+                '<strong>' . wp_html_excerpt( esc_html( wp_unslash( $_REQUEST['s'] ) ), 50, '&hellip;' . '</strong>' )
         );
         echo '</span>';

trunk/src/wp-admin/edit-tags.php

@@ -340 +340 @@
 if ( isset( $_REQUEST['s'] ) && strlen( $_REQUEST['s'] ) ) {
         /* translators: %s: Search query. */
-        printf( '<span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', esc_html( wp_unslash( $_REQUEST['s'] ) ) );
+        printf( '<span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . esc_html( wp_unslash( $_REQUEST['s'] ) ) . '</strong>' );
 }
 ?>

trunk/src/wp-admin/edit.php

@@ -408 +408 @@
 if ( isset( $_REQUEST['s'] ) && strlen( $_REQUEST['s'] ) ) {
         /* translators: %s: Search query. */
-        printf( ' <span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', get_search_query() );
+        printf( ' <span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . get_search_query() . '</strong>' );
 }
 ?>

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -408 +408 @@
 
                         /* translators: %s: Plugin search term. */
-                        printf( __( 'No plugins found for “%s”.' ), $s );
+                        printf( __( 'No plugins found for: %s.' ), '<strong>' . $s . '</strong>' );
 
                         // We assume that somebody who can install plugins in multisite is experienced enough to not need this helper link.

trunk/src/wp-admin/link-manager.php

@@ -106 +106 @@
 if ( isset( $_REQUEST['s'] ) && strlen( $_REQUEST['s'] ) ) {
         /* translators: %s: Search query. */
-        printf( '<span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', esc_html( wp_unslash( $_REQUEST['s'] ) ) );
+        printf( '<span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . esc_html( wp_unslash( $_REQUEST['s'] ) ) . '</strong>' );
 }
 ?>

trunk/src/wp-admin/network/sites.php

@@ -373 +373 @@
 if ( isset( $_REQUEST['s'] ) && strlen( $_REQUEST['s'] ) ) {
         /* translators: %s: Search query. */
-        printf( '<span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', esc_html( $s ) );
+        printf( '<span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . esc_html( $s ) . '</strong>' );
 }
 ?>

trunk/src/wp-admin/network/themes.php

@@ -354 +354 @@
 if ( isset( $_REQUEST['s'] ) && strlen( $_REQUEST['s'] ) ) {
         /* translators: %s: Search query. */
-        printf( '<span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', esc_html( $s ) );
+        printf( '<span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . esc_html( $s ) . '</strong>' );
 }
 ?>

trunk/src/wp-admin/network/users.php

@@ -280 +280 @@
         if ( strlen( $usersearch ) ) {
                 /* translators: %s: Search query. */
-                printf( '<span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', esc_html( $usersearch ) );
+                printf( '<span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . esc_html( $usersearch ) . '</strong>' );
         }
         ?>

trunk/src/wp-admin/plugins.php

@@ -729 +729 @@
 if ( strlen( $s ) ) {
         /* translators: %s: Search query. */
-        printf( '<span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', esc_html( urldecode( $s ) ) );
+        printf( '<span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . esc_html( urldecode( $s ) ) . '</strong>' );
 }
 ?>

trunk/src/wp-admin/upload.php

@@ -277 +277 @@
 if ( isset( $_REQUEST['s'] ) && strlen( $_REQUEST['s'] ) ) {
         /* translators: %s: Search query. */
-        printf( '<span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', get_search_query() );
+        printf( '<span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . get_search_query() . '</strong>' );
 }
 ?>

trunk/src/wp-admin/users.php

@@ -572 +572 @@
 if ( strlen( $usersearch ) ) {
         /* translators: %s: Search query. */
-        printf( '<span class="subtitle">' . __( 'Search results for &#8220;%s&#8221;' ) . '</span>', esc_html( $usersearch ) );
+        printf( '<span class="subtitle">' . __( 'Search results for: %s' ) . '</span>', '<strong>' . esc_html( $usersearch ) . '</strong>' );
 }
 ?>