Changeset 49292

Timestamp:

10/24/2020 12:24:43 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Account for new WP_AUTO_UPDATE_CORE values in auto-updates settings form.

This updates core_auto_updates_settings() to account for the new beta and rc values for the WP_AUTO_UPDATE_CORE constant.

Additionally, recognize these new values as acceptable in Site Health tests.

Follow-up to [48804], [49245], [49254].

Fixes #51319. See #50907.

Location:

trunk/src/wp-admin

Files:

• includes/class-core-upgrader.php (modified) (1 diff)
• includes/class-wp-site-health-auto-updates.php (modified) (1 diff)
• update-core.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-core-upgrader.php

@@ -291 +291 @@
                                 $upgrade_minor = false;
                                 $upgrade_major = false;
-                        } elseif (
-                                true === WP_AUTO_UPDATE_CORE
+                        } elseif ( true === WP_AUTO_UPDATE_CORE
                                 || 'beta' === WP_AUTO_UPDATE_CORE
                                 || 'rc' === WP_AUTO_UPDATE_CORE

trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

@@ -28 +28 @@
         public function run_tests() {
                 $tests = array(
-                        $this->test_constants( 'WP_AUTO_UPDATE_CORE', array( true, 'minor' ) ),
+                        $this->test_constants( 'WP_AUTO_UPDATE_CORE', array( true, 'beta', 'rc', 'minor' ) ),
                         $this->test_wp_version_check_attached(),
                         $this->test_filters_automatic_updater_disabled(),

trunk/src/wp-admin/update-core.php

@@ -323 +323 @@
         $upgrade_major = get_site_option( 'auto_update_core_major', false );
 
+        // WP_AUTO_UPDATE_CORE = true (all), 'beta', 'rc', 'minor', false.
         if ( defined( 'WP_AUTO_UPDATE_CORE' ) ) {
                 if ( false === WP_AUTO_UPDATE_CORE ) {
@@ -329 +330 @@
                         $upgrade_minor = false;
                         $upgrade_major = false;
-                } elseif ( true === WP_AUTO_UPDATE_CORE ) {
+                } elseif ( true === WP_AUTO_UPDATE_CORE
+                        || 'beta' === WP_AUTO_UPDATE_CORE
+                        || 'rc' === WP_AUTO_UPDATE_CORE
+                ) {
                         // ALL updates for core.
                         $upgrade_dev   = true;