Changeset 49294 for trunk/src/wp-admin/includes/class-wp-application-passwords-list-table.php

Timestamp:

10/24/2020 03:32:46 AM (6 years ago)

Author:

TimothyBlynJacobs

Message:

App Passwords: Improve accessibility.

• Make form inputs stacked instead of inline.
• Provide a visible label for the app name.
• Add screen reader text to dismiss button.
• Make "Revoke" button label more descriptive.
• Use aria-disabled instead of disabled to avoid focus loss.
• Display password in a readonly input to assist copy and paste.
• Remove large sections of italic text.
• Use .form-wrap and .form-field to give consistent form styling.
• Improve labeling and placeholder text.

Props alexstine, georgestephanis, afercia, TimothyBlynJacobs.
Fixes #51580.

File:

• trunk/src/wp-admin/includes/class-wp-application-passwords-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-application-passwords-list-table.php

@@ -105 +105 @@
          *
          * @since 5.6.0
-         */
-        public function column_revoke() {
-                submit_button( __( 'Revoke' ), 'delete', 'revoke-application-password', false );
+         *
+         * @param array $item The current application password item.
+         */
+        public function column_revoke( $item ) {
+                submit_button(
+                        __( 'Revoke' ),
+                        'delete',
+                        'revoke-application-password-' . $item['uuid'],
+                        false,
+                        array(
+                                /* translators: %s: the application password's given name. */
+                                'title' => sprintf( __( 'Revoke "%s"' ), $item['name'] ),
+                        )
+                );
         }
 
@@ -221 +232 @@
                                         break;
                                 case 'revoke':
-                                        echo $this->column_revoke();
+                                        printf(
+                                                '<input type="submit" class="button delete" value="%1$s" title="%2$s">',
+                                                esc_attr( __( 'Revoke' ) ),
+                                                /* translators: %s: the application password's given name. */
+                                                esc_attr( sprintf( __( 'Revoke "%s"' ), '{{ data.name }}' ) )
+                                        );
                                         break;
                                 default: