Changeset 49299

Timestamp:

10/24/2020 01:18:50 PM (4 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Support generating comment up links to custom posts controllers.

The comments controller now uses the rest_get_route_for_post function introduced in WordPress 5.5 to generate the link. This function is filterable to allow for custom controllers to properly define their REST API route.

Props dsifford, TimothyBlynJacobs.
Fixes #44152.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -1160 +1160 @@
 
         if ( 0 !== (int) $comment->comment_post_ID ) {
-            $post = get_post( $comment->comment_post_ID );
-
-            if ( ! empty( $post->ID ) ) {
-                $obj  = get_post_type_object( $post->post_type );
-                $base = ! empty( $obj->rest_base ) ? $obj->rest_base : $obj->name;
-
+            $post       = get_post( $comment->comment_post_ID );
+            $post_route = rest_get_route_for_post( $post );
+
+            if ( ! empty( $post->ID ) && $post_route ) {
                 $links['up'] = array(
-                    'href'       => rest_url( 'wp/v2/' . $base . '/' . $comment->comment_post_ID ),
+                    'href'       => rest_url( $post_route ),
                     'embeddable' => true,
                     'post_type'  => $post->post_type,

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -3255 +3255 @@
         );
 
+        if ( $comment->comment_post_ID ) {
+            $this->assertEquals( rest_url( '/wp/v2/posts/' . $comment->comment_post_ID ), $links['up'][0]['href'] );
+        }
+
         if ( 'edit' === $context ) {
             $this->assertSame( $comment->comment_author_email, $data['author_email'] );