Changeset 49301

Timestamp:

10/24/2020 02:10:26 PM (4 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Make template handling resilient against plugins setting the global post.

Plugins shouldn't be setting the global post object during a REST API request, but if they did this could cause unexpected errors when creating a post with a template.

Props Kipperlenny, TimothyBlynJacobs.
Fixes #49695.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1345 +1345 @@
 
         if ( $request['id'] ) {
+            $post             = get_post( $request['id'] );
             $current_template = get_page_template_slug( $request['id'] );
         } else {
+            $post             = null;
             $current_template = '';
         }
@@ -1356 +1358 @@
 
         // If this is a create request, get_post() will return null and wp theme will fallback to the passed post type.
-        $allowed_templates = wp_get_theme()->get_page_templates( get_post( $request['id'] ), $this->post_type );
+        $allowed_templates = wp_get_theme()->get_page_templates( $post, $this->post_type );
 
         if ( isset( $allowed_templates[ $template ] ) ) {