Changeset 49302 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

10/24/2020 04:02:34 PM (6 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Don't validate status if it hasn't changed.

In particular, this allows for sending status=inherit to an attachment if it's current status is inherit. This status would be rejected because it is an "internal" post status which isn't exposed.

As a general rule, a developer should always be able to PUT back a GET response without error.

Props dfenton, pputzer, TimothyBlynJacobs.
Fixes #40399.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -1005 +1005 @@
         $request->set_param( 'post', $attachment_id );
         $response = rest_get_server()->dispatch( $request );
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+    }
+
+    /**
+     * @ticket 40399
+     */
+    public function test_update_item_with_existing_inherit_status() {
+        wp_set_current_user( self::$editor_id );
+        $parent_id     = self::factory()->post->create( array() );
+        $attachment_id = self::factory()->attachment->create_object(
+            $this->test_file,
+            $parent_id,
+            array(
+                'post_mime_type' => 'image/jpeg',
+                'post_excerpt'   => 'A sample caption',
+                'post_author'    => self::$editor_id,
+            )
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/media/' . $attachment_id );
+        $request->set_param( 'status', 'inherit' );
+        $response = rest_get_server()->dispatch( $request );
+
+        $this->assertNotWPError( $response->as_error() );
+        $this->assertEquals( 'inherit', $response->get_data()['status'] );
+    }
+
+    /**
+     * @ticket 40399
+     */
+    public function test_update_item_with_new_inherit_status() {
+        wp_set_current_user( self::$editor_id );
+        $attachment_id = self::factory()->attachment->create_object(
+            $this->test_file,
+            0,
+            array(
+                'post_mime_type' => 'image/jpeg',
+                'post_excerpt'   => 'A sample caption',
+                'post_author'    => self::$editor_id,
+                'post_status'    => 'private',
+            )
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/media/' . $attachment_id );
+        $request->set_param( 'status', 'inherit' );
+        $response = rest_get_server()->dispatch( $request );
+
         $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     }