Changeset 49303 for trunk/src/wp-includes/class-wp-xmlrpc-server.php

Timestamp:

10/24/2020 10:44:38 PM (5 years ago)

Author:

TimothyBlynJacobs

Message:

REST API, XML-RPC: Synchronise empty comment content checks.

The REST API and XML-RPC now uses the same detection methodology for empty comment content as wp_handle_comment_submission(). Specifically, comments now have their content trimmed and '0' is allowed.

Props jaswrks, rmccue, dd32, rachelbaker, Cawa-93, aduth, TimothyBlynJacobs.
Fixes #43177.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -3877 +3877 @@
         }
 
-        if ( empty( $content_struct['content'] ) ) {
-            return new IXR_Error( 403, __( 'Comment is required.' ) );
-        }
-
         $comment = array(
             'comment_post_ID' => $post_id,
-            'comment_content' => $content_struct['content'],
+            'comment_content' => trim( $content_struct['content'] ),
         );
 
@@ -3923 +3919 @@
 
         $comment['comment_parent'] = isset( $content_struct['comment_parent'] ) ? absint( $content_struct['comment_parent'] ) : 0;
+
+        /** This filter is documented in wp-includes/comment.php */
+        $allow_empty = apply_filters( 'allow_empty_comment', false, $comment );
+
+        if ( ! $allow_empty && '' === $comment['comment_content'] ) {
+            return new IXR_Error( 403, __( 'Comment is required.' ) );
+        }
 
         /** This action is documented in wp-includes/class-wp-xmlrpc-server.php */