Changeset 49303 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Timestamp:

10/24/2020 10:44:38 PM (6 years ago)

Author:

TimothyBlynJacobs

Message:

REST API, XML-RPC: Synchronise empty comment content checks.

The REST API and XML-RPC now uses the same detection methodology for empty comment content as wp_handle_comment_submission(). Specifically, comments now have their content trimmed and '0' is allowed.

Props jaswrks, rmccue, dd32, rachelbaker, Cawa-93, aduth, TimothyBlynJacobs.
Fixes #43177.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -1399 +1399 @@
     }
 
+    /**
+     * @ticket 43177
+     */
+    public function test_create_item_invalid_only_spaces_content() {
+        wp_set_current_user( self::$admin_id );
+
+        $params = array(
+            'post'         => self::$post_id,
+            'author_name'  => 'Reverend Lovejoy',
+            'author_email' => 'lovejoy@example.com',
+            'author_url'   => 'http://timothylovejoy.jr',
+            'content'      => '   ',
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertErrorResponse( 'rest_comment_content_invalid', $response, 400 );
+    }
+
+    /**
+     * @ticket 43177
+     */
+    public function test_create_item_allows_0_as_content() {
+        wp_set_current_user( self::$admin_id );
+
+        $params = array(
+            'post'         => self::$post_id,
+            'author_name'  => 'Reverend Lovejoy',
+            'author_email' => 'lovejoy@example.com',
+            'author_url'   => 'http://timothylovejoy.jr',
+            'content'      => '0',
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertSame( 201, $response->get_status() );
+        $this->assertEquals( '0', $response->get_data()['content']['raw'] );
+    }
+
+    /**
+     * @ticket 43177
+     */
+    public function test_create_item_allow_empty_comment_filter() {
+        add_filter( 'allow_empty_comment', '__return_true' );
+
+        wp_set_current_user( self::$admin_id );
+
+        $params = array(
+            'post'         => self::$post_id,
+            'author_name'  => 'Reverend Lovejoy',
+            'author_email' => 'lovejoy@example.com',
+            'author_url'   => 'http://timothylovejoy.jr',
+            'content'      => '',
+        );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/comments' );
+        $request->add_header( 'content-type', 'application/json' );
+        $request->set_body( wp_json_encode( $params ) );
+
+        $response = rest_get_server()->dispatch( $request );
+        $this->assertSame( 201, $response->get_status() );
+        $this->assertEquals( '', $response->get_data()['content']['raw'] );
+    }
+
     public function test_create_item_invalid_date() {
         wp_set_current_user( self::$admin_id );