Changeset 49303 for trunk/tests/phpunit/tests/xmlrpc/wp/newComment.php

Timestamp:

10/24/2020 10:44:38 PM (4 years ago)

Author:

TimothyBlynJacobs

Message:

REST API, XML-RPC: Synchronise empty comment content checks.

The REST API and XML-RPC now uses the same detection methodology for empty comment content as wp_handle_comment_submission(). Specifically, comments now have their content trimmed and '0' is allowed.

Props jaswrks, rmccue, dd32, rachelbaker, Cawa-93, aduth, TimothyBlynJacobs.
Fixes #43177.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/newComment.php (modified) (1 diff)

trunk/tests/phpunit/tests/xmlrpc/wp/newComment.php

@@ -51 +51 @@
     }
 
+    /**
+     * @ticket 43177
+     */
+    public function test_empty_content_multiple_spaces() {
+        $result = $this->myxmlrpcserver->wp_newComment(
+            array(
+                1,
+                'administrator',
+                'administrator',
+                self::$post->ID,
+                array(
+                    'content' => '   ',
+                ),
+            )
+        );
+
+        $this->assertIXRError( $result );
+        $this->assertSame( 403, $result->code );
+    }
+
+    /**
+     * @ticket 43177
+     */
+    public function test_valid_comment_0_content() {
+        $result = $this->myxmlrpcserver->wp_newComment(
+            array(
+                1,
+                'administrator',
+                'administrator',
+                self::$post->ID,
+                array(
+                    'content' => '0',
+                ),
+            )
+        );
+
+        $this->assertNotIXRError( $result );
+    }
+
+    /**
+     * @ticket 43177
+     */
+    public function test_valid_comment_allow_empty_content() {
+        add_filter( 'allow_empty_comment', '__return_true' );
+        $result = $this->myxmlrpcserver->wp_newComment(
+            array(
+                1,
+                'administrator',
+                'administrator',
+                self::$post->ID,
+                array(
+                    'content' => '   ',
+                ),
+            )
+        );
+
+        $this->assertNotIXRError( $result );
+    }
+
     function test_new_comment_post_closed() {
         $post = self::factory()->post->create_and_get(