Changeset 49344

Timestamp:

10/27/2020 07:58:10 PM (4 years ago)

Author:

helen

Message:

Post Formats: You have to pass an array of supported post formats.

This shows a _doing_it_wrong() message and also returns false instead of true if no array of formats is passed in add_theme_support(), avoiding a PHP error.

Post formats maintainership comes full circle. 🙃

Props Mista-Flo, sproutchris, garrett-eclipse.
Fixes #51390.

Location:

trunk

Files:

• src/wp-includes/theme.php (modified) (2 diffs)
• tests/phpunit/tests/post/formats.php (modified) (1 diff)

trunk/src/wp-includes/theme.php

@@ -2482 +2482 @@
  * @since 5.5.0 The `core-block-patterns` feature was added and is enabled by default.
  * @since 5.5.0 The `custom-logo` feature now also accepts 'unlink-homepage-logo'.
+ * @since 5.6.0 The `post-formats` feature now returns doing it wrong if no array is passed
  *
  * @global array $_wp_theme_features
@@ -2524 +2525 @@
 
                 $args[0] = array_intersect( $args[0], array_keys( $post_formats ) );
+            } else {
+                _doing_it_wrong( "add_theme_support( 'post-formats' )", __( 'You need to pass an array of types.' ), '5.6.0' );
+                return false;
             }
             break;

trunk/tests/phpunit/tests/post/formats.php

@@ -7 +7 @@
     function setUp() {
         parent::setUp();
+    }
+
+    /**
+     * @ticket 51390
+     */
+    function test_post_format_doing_it_wrong() {
+        $this->setExpectedIncorrectUsage( "add_theme_support( 'post-formats' )" );
+
+        // The second parameter should be an array.
+        $this->assertFalse( add_theme_support( 'post-formats' ) );
     }