Changeset 49391 for branches/5.4/tests/phpunit/tests/functions.php

Timestamp:

10/29/2020 06:39:14 PM (4 years ago)

Author:

whyisjake

Message:

General: WordPress updates

• XML-RPC: Improve error messages for unprivileged users.
• External Libraries: Disable deserialization in Requests_Utility_FilteredIterator
• Embeds: Disable embeds on deactivated Multisite sites.
• Coding standards: Modify escaping functions to avoid potential false positives.
• XML-RPC: Return error message if attachment ID is incorrect.
• Upgrade/install: Improve logic check when determining installation status.
• Meta: Sanitize meta key before checking protection status.
• Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.

Brings the changes from [49380,49382-49388] to the 5.4 branch.

Props xknown, zieladam, peterwilsoncc, whyisjake, desrosj, dd32.

Location:

branches/5.4

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/functions.php (modified) (1 diff)

branches/5.4/tests/phpunit/tests/functions.php

@@ -255 +255 @@
             $this->assertFalse( is_serialized( $case ), "Test data: $case" );
         }
+    }
+
+    /**
+     * @dataProvider data_serialize_deserialize_objects
+     */
+    function test_deserialize_request_utility_filtered_iterator_objects( $value ) {
+        $serialized = maybe_serialize( $value );
+        if ( is_array( $value ) ) {
+            $deserialized = unserialize( $serialized );
+            $this->assertNotEquals( reset( $value )->count(), reset( $deserialized )->count() );
+        } elseif ( get_class( $value ) === 'Requests_Utility_FilteredIterator' ) {
+            $this->assertNotEquals( $value->count(), unserialize( $serialized )->count() );
+        } else {
+            $this->assertEquals( $value->count(), unserialize( $serialized )->count() );
+        }
+    }
+
+    function data_serialize_deserialize_objects() {
+        return array(
+            array( new Requests_Utility_FilteredIterator( array( 1 ), 'md5' ) ),
+            array( new Requests_Utility_FilteredIterator( array( 1, 2 ), 'sha1' ) ),
+            array( new ArrayIterator( array( 1, 2, 3 ) ) ),
+            array( array( new Requests_Utility_FilteredIterator( array( 1 ), 'md5' ) ) ),
+        );
     }