Changeset 49488

Timestamp:

11/03/2020 03:50:51 PM (6 years ago)

Author:

johnbillion

Message:

Tests: Remove some useless assertions from the image editor tests.

In each of these instances the variable being tested is a directly instantiated object and can never be a WP_Error, unlike when wp_get_image_editor() is used.

See #51344

Location:

trunk/tests/phpunit/tests/image

Files:

• editorGd.php (modified) (1 diff)
• editorImagick.php (modified) (3 diffs)

trunk/tests/phpunit/tests/image/editorGd.php

@@ -532 +532 @@
 
                 $editor = new WP_Image_Editor_GD( $file );
-                                $this->assertNotWPError( $editor );
                                 $editor->load();
                                 $editor->rotate( 180 );

trunk/tests/phpunit/tests/image/editorImagick.php

@@ -466 +466 @@
 
                 $editor = new WP_Image_Editor_Imagick( $file );
-
-                $this->assertNotWPError( $editor );
-
                 $editor->load();
                 $editor->resize( 5, 5 );
@@ -493 +490 @@
 
                 $editor = new WP_Image_Editor_Imagick( $file );
-
-                $this->assertNotWPError( $editor );
-
                 $editor->load();
 
@@ -526 +520 @@
                 $image_editor = new WP_Image_Editor_Imagick( $save_to_file );
                 $image_editor->load();
-                $this->assertNotWPError( $image_editor );
                 $image_editor->rotate( 180 );
                 $image_editor->save( $save_to_file );