Changeset 49520 for branches/4.8

Timestamp:

11/06/2020 04:52:40 PM (4 years ago)

Author:

desrosj

Message:

Media: Improve and fix rotate/flip image tests.

Fix off-by-one error in pixel color checks for rotate and flip image tests. Change to using PNG with single pixel to ensure that errors are caught in the future, rather than lost in JPEG noise.

Props Fuegas, mikeschroder.
Merges [45067] to the 4.8 branch.
See #46073, #48301.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• tests/phpunit/data/images/one-blue-pixel-100x100.png (copied) (copied from trunk/tests/phpunit/data/images/one-blue-pixel-100x100.png)
• tests/phpunit/tests/image/editor_imagick.php (modified) (5 diffs)

branches/4.8/tests/phpunit/tests/image/editor_imagick.php

@@ -421 +421 @@
      */
     public function test_rotate() {
-        $file = DIR_TESTDATA . '/images/gradient-square.jpg';
+        $file = DIR_TESTDATA . '/images/one-blue-pixel-100x100.png';
 
         $imagick_image_editor = new WP_Image_Editor_Imagick( $file );
@@ -429 +429 @@
         $property->setAccessible( true );
 
-        $color_top_left = $property->getValue( $imagick_image_editor )->getImagePixelColor( 1, 1 )->getColor();
+        $color_top_left = $property->getValue( $imagick_image_editor )->getImagePixelColor( 0, 0 )->getColor();
 
         $imagick_image_editor->rotate( 180 );
@@ -440 +440 @@
      */
     public function test_flip() {
-        $file = DIR_TESTDATA . '/images/gradient-square.jpg';
+        $file = DIR_TESTDATA . '/images/one-blue-pixel-100x100.png';
 
         $imagick_image_editor = new WP_Image_Editor_Imagick( $file );
@@ -448 +448 @@
         $property->setAccessible( true );
 
-        $color_top_left = $property->getValue( $imagick_image_editor )->getImagePixelColor( 1, 1 )->getColor();
+        $color_top_left = $property->getValue( $imagick_image_editor )->getImagePixelColor( 0, 0 )->getColor();
 
         $imagick_image_editor->flip( true, false );
@@ -466 +466 @@
 
         $this->assertNotInstanceOf( 'WP_Error', $editor );
-        
+
         $editor->load();
         $editor->resize( 5, 5 );