Changeset 49537 for trunk/src/wp-admin/site-health.php

Timestamp:

11/08/2020 09:50:07 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Validate the test result data format in JS before using it.

This will discard any invalid responses instead of causing fatal errors.

It also makes badges optional, on the same basis as actions are optional. They are expected, but there may be situations where they are not present.

Props Clorith, dogwithblog, kraftbj, whyisjake, SergeyBiryukov.
Fixes #50145.

File:

• trunk/src/wp-admin/site-health.php (modified) (1 diff)

trunk/src/wp-admin/site-health.php

@@ -145 +145 @@
         <button aria-expanded="false" class="health-check-accordion-trigger" aria-controls="health-check-accordion-block-{{ data.test }}" type="button">
             <span class="title">{{ data.label }}</span>
-            <span class="badge {{ data.badge.color }}">{{ data.badge.label }}</span>
+            <# if ( data.badge ) { #>
+                <span class="badge {{ data.badge.color }}">{{ data.badge.label }}</span>
+            <# } #>
             <span class="icon"></span>
         </button>