Changeset 49547 for trunk/tests/phpunit/tests/auth.php

Timestamp:

11/09/2020 03:43:14 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [48937], [48939], [48940], [48944].

See #38266.

File:

• trunk/tests/phpunit/tests/auth.php (modified) (11 diffs)

trunk/tests/phpunit/tests/auth.php

@@ -452 +452 @@
                 $_SERVER['PHP_AUTH_PW']   = 'http_auth_pass';
 
-                $this->assertEquals(
-                        0,
+                $this->assertSame(
+                        null,
                         wp_validate_application_password( null ),
                         'Regular user account password should not be allowed for API authentication'
@@ -461 +461 @@
                 $_SERVER['PHP_AUTH_PW'] = $user_app_password;
 
-                $this->assertEquals(
+                $this->assertSame(
                         $user_id,
                         wp_validate_application_password( null ),
@@ -492 +492 @@
                 $error = wp_authenticate_application_password( null, 'idonotexist', 'password' );
                 $this->assertWPError( $error );
-                $this->assertEquals( 'invalid_username', $error->get_error_code() );
+                $this->assertSame( 'invalid_username', $error->get_error_code() );
         }
 
@@ -503 +503 @@
                 $error = wp_authenticate_application_password( null, 'idonotexist@example.org', 'password' );
                 $this->assertWPError( $error );
-                $this->assertEquals( 'invalid_email', $error->get_error_code() );
+                $this->assertSame( 'invalid_email', $error->get_error_code() );
         }
 
@@ -515 +515 @@
                 $error = wp_authenticate_application_password( null, self::$_user->user_login, 'password' );
                 $this->assertWPError( $error );
-                $this->assertEquals( 'application_passwords_disabled', $error->get_error_code() );
+                $this->assertSame( 'application_passwords_disabled', $error->get_error_code() );
         }
 
@@ -528 +528 @@
                 $error = wp_authenticate_application_password( null, self::$_user->user_login, 'password' );
                 $this->assertWPError( $error );
-                $this->assertEquals( 'application_passwords_disabled', $error->get_error_code() );
+                $this->assertSame( 'application_passwords_disabled', $error->get_error_code() );
         }
 
@@ -540 +540 @@
                 $error = wp_authenticate_application_password( null, self::$_user->user_login, 'password' );
                 $this->assertWPError( $error );
-                $this->assertEquals( 'incorrect_password', $error->get_error_code() );
+                $this->assertSame( 'incorrect_password', $error->get_error_code() );
         }
 
@@ -561 +561 @@
                 $error = wp_authenticate_application_password( null, self::$_user->user_login, $password );
                 $this->assertWPError( $error );
-                $this->assertEquals( 'my_code', $error->get_error_code() );
+                $this->assertSame( 'my_code', $error->get_error_code() );
         }
 
@@ -575 +575 @@
                 $user = wp_authenticate_application_password( null, self::$_user->user_login, $password );
                 $this->assertInstanceOf( WP_User::class, $user );
-                $this->assertEquals( self::$user_id, $user->ID );
+                $this->assertSame( self::$user_id, $user->ID );
         }
 
@@ -589 +589 @@
                 $user = wp_authenticate_application_password( null, self::$_user->user_email, $password );
                 $this->assertInstanceOf( WP_User::class, $user );
-                $this->assertEquals( self::$user_id, $user->ID );
+                $this->assertSame( self::$user_id, $user->ID );
         }
 
@@ -603 +603 @@
                 $user = wp_authenticate_application_password( null, self::$_user->user_email, WP_Application_Passwords::chunk_password( $password ) );
                 $this->assertInstanceOf( WP_User::class, $user );
-                $this->assertEquals( self::$user_id, $user->ID );
+                $this->assertSame( self::$user_id, $user->ID );
         }
 }