Context Navigation

← Previous Change
Next Change →

rest-comments-controller.php

Timestamp:

11/09/2020 03:43:14 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [48937], [48939], [48940], [48944].

See #38266.

File:

: 1 edited

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (3 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

-              r49303
+              r49547
                 $response = rest_get_server()->dispatch( $request );
                 $this->assertSame( 201, $response->get_status() );
                 $this->assertEquals( '0', $response->get_data()['content']['raw'] );
+                $this->assertSame( '0', $response->get_data()['content']['raw'] );
+        }
 …
                 $response = rest_get_server()->dispatch( $request );
                 $this->assertSame( 201, $response->get_status() );
                 $this->assertEquals( '', $response->get_data()['content']['raw'] );
+                $this->assertSame( '', $response->get_data()['content']['raw'] );
+        }
 …
                 if ( $comment->comment_post_ID ) {
                         $this->assertEquals( rest_url( '/wp/v2/posts/' . $comment->comment_post_ID ), $links['up'][0]['href'] );
+                        $this->assertSame( rest_url( '/wp/v2/posts/' . $comment->comment_post_ID ), $links['up'][0]['href'] );
+                }

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 49547 for trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Legend:

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

Download in other formats: