Context Navigation

← Previous Change
Next Change →

rest-server.php

Timestamp:

11/09/2020 03:43:14 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [48937], [48939], [48940], [48944].

See #38266.

File:

: 1 edited

trunk/tests/phpunit/tests/rest-api/rest-server.php (modified) (9 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/rest-api/rest-server.php

-              r49257
+              r49547
                 $this->assertCount( 1, $events );
                 $this->assertWPError( $events[0]['args'][0] );
                 $this->assertEquals( 'rest_invalid_handler', $events[0]['args'][0]->get_error_code() );
+                $this->assertSame( 'rest_invalid_handler', $events[0]['args'][0]->get_error_code() );
+        }
 …
                 $this->assertCount( 1, $events );
                 $this->assertWPError( $events[0]['args'][0] );
                 $this->assertEquals( 'rest_invalid_param', $events[0]['args'][0]->get_error_code() );
+                $this->assertSame( 'rest_invalid_param', $events[0]['args'][0]->get_error_code() );
+        }
 …
                 $response = rest_do_request( $request );
                 $this->assertEquals( 207, $response->get_status() );
+                $this->assertSame( 207, $response->get_status() );
                 if ( $allowed ) {
                         $this->assertEquals( 'data', $response->get_data()['responses'][0]['body'] );
+                        $this->assertSame( 'data', $response->get_data()['responses'][0]['body'] );
                 } else {
                         $this->assertEquals( 'rest_batch_not_allowed', $response->get_data()['responses'][0]['body']['code'] );
+                        $this->assertSame( 'rest_batch_not_allowed', $response->get_data()['responses'][0]['body']['code'] );
+                }
+        }
 …
                 $data     = $response->get_data();
                 $this->assertEquals( 207, $response->get_status() );
+                $this->assertSame( 207, $response->get_status() );
                 $this->assertArrayHasKey( 'failed', $data );
                 $this->assertEquals( 'validation', $data['failed'] );
+                $this->assertSame( 'validation', $data['failed'] );
                 $this->assertCount( 2, $data['responses'] );
                 $this->assertNull( $data['responses'][0] );
                 $this->assertEquals( 400, $data['responses'][1]['status'] );
+                $this->assertSame( 400, $data['responses'][1]['status'] );
                 $this->assertFalse( get_option( 'test_project' ) );
+        }
 …
                 $data     = $response->get_data();
                 $this->assertEquals( 207, $response->get_status() );
+                $this->assertSame( 207, $response->get_status() );
                 $this->assertArrayNotHasKey( 'failed', $data );
                 $this->assertCount( 2, $data['responses'] );
                 $this->assertEquals( 'gutenberg', $data['responses'][0]['body'] );
                 $this->assertEquals( 'WordPress', $data['responses'][1]['body'] );
+                $this->assertSame( 'gutenberg', $data['responses'][0]['body'] );
+                $this->assertSame( 'WordPress', $data['responses'][1]['body'] );
+        }
 …
                                 'methods'             => array( 'POST', 'DELETE' ),
                                 'callback'            => function ( WP_REST_Request $request ) {
                                         $this->assertEquals( 'DELETE', $request->get_method() );
                                         $this->assertEquals( '/test-ns/v1/test/5', $request->get_route() );
                                         $this->assertEquals( array( 'id' => '5' ), $request->get_url_params() );
                                         $this->assertEquals( array( 'query' => 'param' ), $request->get_query_params() );
                                         $this->assertEquals( array( 'project' => 'gutenberg' ), $request->get_body_params() );
                                         $this->assertEquals( array( 'my_header' => array( 'my-value' ) ), $request->get_headers() );
+                                        $this->assertSame( 'DELETE', $request->get_method() );
+                                        $this->assertSame( '/test-ns/v1/test/5', $request->get_route() );
+                                        $this->assertSame( array( 'id' => '5' ), $request->get_url_params() );
+                                        $this->assertSame( array( 'query' => 'param' ), $request->get_query_params() );
+                                        $this->assertSame( array( 'project' => 'gutenberg' ), $request->get_body_params() );
+                                        $this->assertSame( array( 'my_header' => array( 'my-value' ) ), $request->get_headers() );
                                         return new WP_REST_Response( 'test' );
 …
                 $response = rest_get_server()->dispatch( $request );
                 $this->assertEquals( 207, $response->get_status() );
                 $this->assertEquals( 'test', $response->get_data()['responses'][0]['body'] );
+                $this->assertSame( 207, $response->get_status() );
+                $this->assertSame( 'test', $response->get_data()['responses'][0]['body'] );
+        }
 …
                 $data     = $response->get_data();
                 $this->assertEquals( 207, $response->get_status() );
+                $this->assertSame( 207, $response->get_status() );
                 $this->assertArrayNotHasKey( 'failed', $data );
                 $this->assertCount( 2, $data['responses'] );
                 $this->assertEquals( 'gutenberg', $data['responses'][0]['body'] );
                 $this->assertEquals( 400, $data['responses'][1]['status'] );
                 $this->assertEquals( 'gutenberg', get_option( 'test_project' ) );
+                $this->assertSame( 'gutenberg', $data['responses'][0]['body'] );
+                $this->assertSame( 400, $data['responses'][1]['status'] );
+                $this->assertSame( 'gutenberg', get_option( 'test_project' ) );
+        }
 …
                 $response = rest_get_server()->dispatch( $request );
                 $this->assertEquals( 400, $response->get_status() );
+                $this->assertSame( 400, $response->get_status() );
+        }

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 49547 for trunk/tests/phpunit/tests/rest-api/rest-server.php

Legend:

trunk/tests/phpunit/tests/rest-api/rest-server.php

Download in other formats: