Changeset 49560

Timestamp:

11/10/2020 08:38:59 PM (4 years ago)

Author:

helen

Message:

Widgets: Do not use wrapping container in the admin.

This is due to the new before|after_sidebar args, which are empty by default, but can introduce markup that causes admin JS to stop working.

Also adds documentation for the sprintf() on before_sidebar.

Props audrasjb, lpointet.
See #19709.

File:

• trunk/src/wp-includes/widgets.php (modified) (3 diffs)

trunk/src/wp-includes/widgets.php

@@ -244 +244 @@
  *                                  Default is a closing h2 element.
  *     @type string $before_sidebar HTML content to prepend to the sidebar when displayed.
+ *                                  Receives the '$id' argument as %1$s and '$class' as %2$s.
  *                                  Outputs after the {@see 'dynamic_sidebar_before'} action.
  *                                  Default empty string.
@@ -719 +720 @@
     do_action( 'dynamic_sidebar_before', $index, true );
 
-    if ( ! empty( $sidebar['before_sidebar'] ) ) {
+    if ( ! is_admin() && ! empty( $sidebar['before_sidebar'] ) ) {
         echo $sidebar['before_sidebar'];
     }
@@ -824 +825 @@
     }
 
-    if ( ! empty( $sidebar['after_sidebar'] ) ) {
+    if ( ! is_admin() && ! empty( $sidebar['after_sidebar'] ) ) {
         echo $sidebar['after_sidebar'];
     }