Changeset 49571

Timestamp:

11/12/2020 05:23:44 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Only enforce PHP extension requirements when running core tests.

This allows other users of the WordPress unit test suite framework to run their own unit tests without needing the GD extension, which should only be a requirement if running core tests.

Follow-up to [49535].

Props jamescollins.
Fixes #50640.

Location:

trunk

Files:

• composer.json (modified) (1 diff)
• composer.lock (modified) (3 diffs)
• tests/phpunit/includes/bootstrap.php (modified) (1 diff)

trunk/composer.json

@@ -17 +17 @@
         "wp-coding-standards/wpcs": "~2.3.0",
         "phpcompatibility/phpcompatibility-wp": "^2.1.0",
-        "phpunit/phpunit": "^7.5",
-        "ext-gd": "*"
+        "phpunit/phpunit": "^7.5"
     },
     "autoload-dev": {

trunk/composer.lock

@@ -5 +5 @@
         "This file is @generated automatically"
     ],
-    "content-hash": "fcf040d9233a22165eeffaeb98694436",
+    "content-hash": "463db2b4afb439fb63d93173c0852e27",
     "packages": [],
     "packages-dev": [
@@ -131 +131 @@
                 "constructor",
                 "instantiate"
-            ],
-            "funding": [
-                {
-                    "url": "https://www.doctrine-project.org/sponsorship.html",
-                    "type": "custom"
-                },
-                {
-                    "url": "https://www.patreon.com/phpdoctrine",
-                    "type": "patreon"
-                },
-                {
-                    "url": "https://tidelift.com/funding/github/packagist/doctrine%2Finstantiator",
-                    "type": "tidelift"
-                }
             ],
             "time": "2020-05-29T17:27:14+00:00"
@@ -1852 +1838 @@
         "php": ">=5.6"
     },
-    "platform-dev": {
-        "ext-gd": "*"
-    },
+    "platform-dev": [],
     "plugin-api-version": "1.1.0"
 }

trunk/tests/phpunit/includes/bootstrap.php

@@ -54 +54 @@
 }
 
-$required_extensions = array(
-    'gd',
-);
-$missing_extensions  = array();
-
-foreach ( $required_extensions as $extension ) {
-    if ( ! extension_loaded( $extension ) ) {
-        $missing_extensions[] = $extension;
-    }
-}
-
-if ( $missing_extensions ) {
-    printf(
-        "Error: The following required PHP extensions are missing from the testing environment: %s.\n",
-        implode( ', ', $missing_extensions )
+// If running core tests, check if all the required PHP extensions are loaded before running the test suite.
+if ( defined( 'WP_RUN_CORE_TESTS' ) && WP_RUN_CORE_TESTS ) {
+    $required_extensions = array(
+        'gd',
     );
-    echo "Please make sure they are installed and enabled.\n",
-    exit( 1 );
+    $missing_extensions  = array();
+
+    foreach ( $required_extensions as $extension ) {
+        if ( ! extension_loaded( $extension ) ) {
+            $missing_extensions[] = $extension;
+        }
+    }
+
+    if ( $missing_extensions ) {
+        printf(
+            "Error: The following required PHP extensions are missing from the testing environment: %s.\n",
+            implode( ', ', $missing_extensions )
+        );
+        echo "Please make sure they are installed and enabled.\n",
+        exit( 1 );
+    }
 }