Changeset 49603 for trunk/tests/phpunit/includes/testcase-canonical.php

Timestamp:

11/15/2020 01:59:32 PM (3 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.

This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its $factory parameter.

See #51344

File:

• trunk/tests/phpunit/includes/testcase-canonical.php (modified) (3 diffs)

trunk/tests/phpunit/includes/testcase-canonical.php

@@ -16 +16 @@
     public $structure = '/%year%/%monthnum%/%day%/%postname%/';
 
-    public static function wpSetUpBeforeClass( $factory ) {
+    public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
         self::generate_shared_fixtures( $factory );
     }
@@ -42 +42 @@
      * @since 4.1.0
      */
-    public static function generate_shared_fixtures( $factory ) {
+    public static function generate_shared_fixtures( WP_UnitTest_Factory $factory ) {
         self::$old_current_user = get_current_user_id();
         self::$author_id        = $factory->user->create( array( 'user_login' => 'canonical-author' ) );
@@ -53 +53 @@
 
         // Already created by install defaults:
-        // self::factory()->term->create( array( 'taxonomy' => 'category', 'name' => 'uncategorized' ) );
+        // $factory->term->create( array( 'taxonomy' => 'category', 'name' => 'uncategorized' ) );
 
         self::$post_ids[] = $factory->post->create(