Changeset 49603 for trunk/tests/phpunit/tests/comment/getCommentLink.php

Timestamp:

11/15/2020 01:59:32 PM (6 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.

This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its $factory parameter.

See #51344

File:

• trunk/tests/phpunit/tests/comment/getCommentLink.php (modified) (6 diffs)

trunk/tests/phpunit/tests/comment/getCommentLink.php

@@ -8 +8 @@
         protected static $comments = array();
 
-        public static function wpSetUpBeforeClass( $factory ) {
+        public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
                 $now     = time();
-                self::$p = self::factory()->post->create();
+                self::$p = $factory->post->create();
 
-                self::$comments[] = self::factory()->comment->create(
+                self::$comments[] = $factory->comment->create(
                         array(
                                 'comment_post_ID'  => self::$p,
@@ -19 +19 @@
                         )
                 );
-                self::$comments[] = self::factory()->comment->create(
+                self::$comments[] = $factory->comment->create(
                         array(
                                 'comment_post_ID'  => self::$p,
@@ -26 +26 @@
                         )
                 );
-                self::$comments[] = self::factory()->comment->create(
+                self::$comments[] = $factory->comment->create(
                         array(
                                 'comment_post_ID'  => self::$p,
@@ -33 +33 @@
                         )
                 );
-                self::$comments[] = self::factory()->comment->create(
+                self::$comments[] = $factory->comment->create(
                         array(
                                 'comment_post_ID'  => self::$p,
@@ -40 +40 @@
                         )
                 );
-                self::$comments[] = self::factory()->comment->create(
+                self::$comments[] = $factory->comment->create(
                         array(
                                 'comment_post_ID'  => self::$p,
@@ -47 +47 @@
                         )
                 );
-                self::$comments[] = self::factory()->comment->create(
+                self::$comments[] = $factory->comment->create(
                         array(
                                 'comment_post_ID'  => self::$p,