Changeset 49603 for trunk/tests/phpunit/tests/post/wpListPages.php

Timestamp:

11/15/2020 01:59:32 PM (4 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.

This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its $factory parameter.

See #51344

File:

• trunk/tests/phpunit/tests/post/wpListPages.php (modified) (6 diffs)

trunk/tests/phpunit/tests/post/wpListPages.php

@@ -54 +54 @@
     public static $time;
 
-    public static function wpSetupBeforeClass() {
+    public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
         self::$time = time();
 
         $post_date = gmdate( 'Y-m-d H:i:s', self::$time );
 
-        self::$editor = self::factory()->user->create( array( 'role' => 'editor' ) );
-        self::$author = self::factory()->user->create( array( 'role' => 'author' ) );
-
-        self::$parent_1 = self::factory()->post->create(
+        self::$editor = $factory->user->create( array( 'role' => 'editor' ) );
+        self::$author = $factory->user->create( array( 'role' => 'author' ) );
+
+        self::$parent_1 = $factory->post->create(
             array(
                 'post_author' => self::$editor,
@@ -71 +71 @@
         );
 
-        self::$parent_2 = self::factory()->post->create(
+        self::$parent_2 = $factory->post->create(
             array(
                 'post_type'  => 'page',
@@ -79 +79 @@
         );
 
-        self::$parent_3 = self::factory()->post->create(
+        self::$parent_3 = $factory->post->create(
             array(
                 'post_author' => self::$author,
@@ -89 +89 @@
 
         foreach ( array( self::$parent_1, self::$parent_2, self::$parent_3 ) as $page ) {
-            self::$children[ $page ][] = self::factory()->post->create(
+            self::$children[ $page ][] = $factory->post->create(
                 array(
                     'post_parent' => $page,
@@ -97 +97 @@
                 )
             );
-            self::$children[ $page ][] = self::factory()->post->create(
+            self::$children[ $page ][] = $factory->post->create(
                 array(
                     'post_parent' => $page,
@@ -105 +105 @@
                 )
             );
-            self::$children[ $page ][] = self::factory()->post->create(
+            self::$children[ $page ][] = $factory->post->create(
                 array(
                     'post_parent' => $page,