Changeset 49603 for trunk/tests/phpunit/tests/query/commentCount.php

Timestamp:

11/15/2020 01:59:32 PM (6 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.

This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its $factory parameter.

See #51344

File:

• trunk/tests/phpunit/tests/query/commentCount.php (modified) (5 diffs)

trunk/tests/phpunit/tests/query/commentCount.php

@@ -19 +19 @@
         }
 
-        public static function wpSetUpBeforeClass( $factory ) {
-                $post_id             = self::factory()->post->create(
+        public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+                $post_id             = $factory->post->create(
                         array(
                                 'post_content' => 1 . rand_str() . ' about',
@@ -27 +27 @@
                 );
                 self::$post_ids[1][] = $post_id;
-                self::factory()->comment->create( array( 'comment_post_ID' => $post_id ) );
-
-                $post_id             = self::factory()->post->create(
+                $factory->comment->create( array( 'comment_post_ID' => $post_id ) );
+
+                $post_id             = $factory->post->create(
                         array(
                                 'post_content' => 1 . rand_str() . ' about',
@@ -37 +37 @@
                 self::$post_ids[4][] = $post_id;
                 for ( $i = 0; $i < 4; $i++ ) {
-                        self::factory()->comment->create( array( 'comment_post_ID' => $post_id ) );
-                }
-
-                $post_id             = self::factory()->post->create(
+                        $factory->comment->create( array( 'comment_post_ID' => $post_id ) );
+                }
+
+                $post_id             = $factory->post->create(
                         array(
                                 'post_content' => 1 . rand_str() . ' about',
@@ -48 +48 @@
                 self::$post_ids[5][] = $post_id;
                 for ( $i = 0; $i < 5; $i++ ) {
-                        self::factory()->comment->create( array( 'comment_post_ID' => $post_id ) );
-                }
-
-                $post_id             = self::factory()->post->create(
+                        $factory->comment->create( array( 'comment_post_ID' => $post_id ) );
+                }
+
+                $post_id             = $factory->post->create(
                         array(
                                 'post_content' => 1 . rand_str() . ' about',
@@ -59 +59 @@
                 self::$post_ids[5][] = $post_id;
                 for ( $i = 0; $i < 5; $i++ ) {
-                        self::factory()->comment->create( array( 'comment_post_ID' => $post_id ) );
+                        $factory->comment->create( array( 'comment_post_ID' => $post_id ) );
                 }
         }