Changeset 49603 for trunk/tests/phpunit/tests/rewrite/oldDateRedirect.php

Timestamp:

11/15/2020 01:59:32 PM (4 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Standardise the name, signature, and usage of the wpSetUpBeforeClass() method that's used in test classes.

This brings consistency to this often-used method, and allows IDEs to provide help to developers when using its $factory parameter.

See #51344

File:

• trunk/tests/phpunit/tests/rewrite/oldDateRedirect.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rewrite/oldDateRedirect.php

@@ -11 +11 @@
     public static $attachment_id;
 
-    public static function wpSetUpBeforeClass() {
-        self::$post_id = self::factory()->post->create(
+    public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+        self::$post_id = $factory->post->create(
             array(
                 'post_title' => 'Foo Bar',
@@ -19 +19 @@
         );
 
-        self::$attachment_id = self::factory()->attachment->create_object(
+        self::$attachment_id = $factory->attachment->create_object(
             array(
                 'file'           => DIR_TESTDATA . '/images/canola.jpg',