Changeset 49604

Timestamp:

11/15/2020 02:17:31 PM (4 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Ensure user capability assertions are performed for all default roles.

The existing assertions were erroneously placed outside the iteration of all users, and therefore were only run against the last user in the list, which is the Subscriber role.

See #51344, #32394

File:

• trunk/tests/phpunit/tests/user/capabilities.php (modified) (3 diffs)

trunk/tests/phpunit/tests/user/capabilities.php

@@ -9 +9 @@
 class Tests_User_Capabilities extends WP_UnitTestCase {
 
-    protected static $users       = array(
+    /**
+     * @var WP_User[] $users
+     */
+    protected static $users = array(
         'administrator' => null,
         'editor'        => null,
@@ -16 +19 @@
         'subscriber'    => null,
     );
+
+    /**
+     * @var WP_User $super_admin
+     */
     protected static $super_admin = null;
 
+    /**
+     * @var int $block_id
+     */
     protected static $block_id;
 
@@ -533 +543 @@
                 }
             }
-        }
-
-        $this->assertFalse( $user->has_cap( 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );
-        $this->assertFalse( user_can( $user, 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );
-
-        $this->assertFalse( $user->has_cap( 'do_not_allow' ), "User with the {$role} role should not have the do_not_allow capability" );
-        $this->assertFalse( user_can( $user, 'do_not_allow' ), "User with the {$role} role should not have the do_not_allow capability" );
-
-        $this->assertTrue( $user->has_cap( 'exist' ), "User with the {$role} role should have the exist capability" );
-        $this->assertTrue( user_can( $user, 'exist' ), "User with the {$role} role should have the exist capability" );
+
+            $this->assertFalse( $user->has_cap( 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );
+            $this->assertFalse( user_can( $user, 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );
+
+            $this->assertFalse( $user->has_cap( 'do_not_allow' ), "User with the {$role} role should not have the do_not_allow capability" );
+            $this->assertFalse( user_can( $user, 'do_not_allow' ), "User with the {$role} role should not have the do_not_allow capability" );
+
+            $this->assertTrue( $user->has_cap( 'exist' ), "User with the {$role} role should have the exist capability" );
+            $this->assertTrue( user_can( $user, 'exist' ), "User with the {$role} role should have the exist capability" );
+        }
     }