Changeset 49605

Timestamp:

11/15/2020 02:57:39 PM (6 years ago)

Author:

johnbillion

Message:

Built/Test Tools: Switch to a data provider for the default user role and capability tests.

This test previously performed 1,010 assertions, and a failure in any one would prevent the other assertions from running. Using a data provider means simultaneous failures will all be reported at once.

See #51344, #32394

File:

• trunk/tests/phpunit/tests/user/capabilities.php (modified) (3 diffs)

trunk/tests/phpunit/tests/user/capabilities.php

@@ -323 +323 @@
                         'assign_post_tags'            => array( 'administrator', 'editor', 'author', 'contributor' ),
                 );
+        }
+
+        public function dataAllCapsAndRoles() {
+                $data = array();
+                $caps = $this->getAllCapsAndRoles();
+
+                foreach ( self::$users as $role => $null ) {
+                        foreach ( $caps as $cap => $roles ) {
+                                $data[] = array(
+                                        $role,
+                                        $cap,
+                                );
+                        }
+                }
+
+                return $data;
         }
 
@@ -521 +537 @@
 
         /**
-         * Test the default roles and caps.
-         */
-        function test_all_roles_and_caps() {
-                $caps = $this->getAllCapsAndRoles();
-
+         * Test the default capabilities of all user roles.
+         *
+         * @dataProvider dataAllCapsAndRoles
+         */
+        function test_default_caps_for_all_roles( $role, $cap ) {
+                $user         = self::$users[ $role ];
+                $roles_by_cap = $this->getAllCapsAndRoles();
+
+                if ( in_array( $role, $roles_by_cap[ $cap ], true ) ) {
+                        $this->assertTrue( $user->has_cap( $cap ), "User with the {$role} role should have the {$cap} capability" );
+                        $this->assertTrue( user_can( $user, $cap ), "User with the {$role} role should have the {$cap} capability" );
+                } else {
+                        $this->assertFalse( $user->has_cap( $cap ), "User with the {$role} role should not have the {$cap} capability" );
+                        $this->assertFalse( user_can( $user, $cap ), "User with the {$role} role should not have the {$cap} capability" );
+                }
+        }
+
+        /**
+         * Test miscellaneous capabilities of all user roles.
+         */
+        function test_other_caps_for_all_roles() {
                 foreach ( self::$users as $role => $user ) {
-
                         // Make sure the user is valid.
                         $this->assertTrue( $user->exists(), "User with {$role} role does not exist" );
@@ -533 +564 @@
                         // Make sure the role name is correct.
                         $this->assertSame( array( $role ), $user->roles, "User should only have the {$role} role" );
-
-                        foreach ( $caps as $cap => $roles ) {
-                                if ( in_array( $role, $roles, true ) ) {
-                                        $this->assertTrue( $user->has_cap( $cap ), "User with the {$role} role should have the {$cap} capability" );
-                                        $this->assertTrue( user_can( $user, $cap ), "User with the {$role} role should have the {$cap} capability" );
-                                } else {
-                                        $this->assertFalse( $user->has_cap( $cap ), "User with the {$role} role should not have the {$cap} capability" );
-                                        $this->assertFalse( user_can( $user, $cap ), "User with the {$role} role should not have the {$cap} capability" );
-                                }
-                        }
 
                         $this->assertFalse( $user->has_cap( 'start_a_fire' ), "User with the {$role} role should not have a custom capability" );