Changeset 49622 for trunk/src/wp-includes/link-template.php

Timestamp:

11/17/2020 03:27:07 AM (4 years ago)

Author:

peterwilsoncc

Message:

Permalinks: Prevent attachment pages 404ing following [49563].

This largely reverts [49563] due to attachment pages returning 404: File not found errors when they use the inherit status.

Permalink changes to attachment pages are retained when they are descendants of trashed or deleted posts.

Props Toro_Unit, helen, johnbillion, peterwilsoncc.
Fixes #51776.
See #5272.

File:

• trunk/src/wp-includes/link-template.php (modified) (2 diffs)

trunk/src/wp-includes/link-template.php

@@ -165 +165 @@
     $permalink = apply_filters( 'pre_post_link', $permalink, $post, $leavename );
 
-    if ( $permalink && ! in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft', 'future' ), true ) ) {
+    if (
+        $permalink &&
+        ! in_array( $post->post_status, array( 'draft', 'pending', 'auto-draft', 'future', 'trash' ), true )
+    ) {
 
         $category = '';
@@ -419 +422 @@
     if ( $parent && ! in_array( $parent->post_type, get_post_types(), true ) ) {
         $parent = false;
-    }
-
-    if ( $parent ) {
-        $parent_status_obj = get_post_status_object( get_post_status( $post->post_parent ) );
-        if (
-            ! is_post_type_viewable( get_post_type( $post->post_parent ) ) ||
-            $parent_status_obj->internal ||
-            $parent_status_obj->protected
-        ) {
-            $parent = false;
-        }
     }