Changeset 49624

Timestamp:

11/17/2020 04:29:02 AM (4 years ago)

Author:

noisysocks

Message:

Customize: Ensure multiple CSS classes are passed to nav_menu_link_attributes as an array

When multiple CSS classes are added to a menu item, the nav_menu_link_attributes
filter should be called with $item->classes set to an array of CSS class names.

When previewing in the Customizer, however, a single string was being passed to
$item->classes because WP_Customize_Nav_Menu_Item_Setting::preview() bypasses
wp_update_nav_menu_item() and instead uses filter_wp_get_nav_menu_items().

The fix is to make filter_wp_get_nav_menu_items() match what
wp_update_nav_menu_item() does and split the string into an array.

Fixes #43113.
Props dlh.

Location:

trunk

Files:

• src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php (modified) (1 diff)
• tests/phpunit/tests/customize/nav-menu-item-setting.php (modified) (2 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

@@ -606 +606 @@
         }
 
+        // 'classes' should be an array, as in wp_setup_nav_menu_item().
+        if ( isset( $item->classes ) && is_scalar( $item->classes ) ) {
+            $item->classes = explode( ' ', $item->classes );
+        }
+
         $item->ID    = $this->post_id;
         $item->db_id = $this->post_id;

trunk/tests/phpunit/tests/customize/nav-menu-item-setting.php

@@ -907 +907 @@
             'attr_title'       => '">att \o/ o\'o empted <b>baddie</b>',
             'description'      => 'Attempted \o/ o\'o <b>markup</b>',
-            'classes'          => '',
+            'classes'          => 'class-1 class-2',
             'xfn'              => '',
             'status'           => 'publish',
@@ -941 +941 @@
         $this->assertSame( $expected, $nav_menu_item->attr_title );
         $this->assertSame( 'Attempted \o/ o&#8217;o markup', $nav_menu_item->description );
+        $this->assertSame( array( 'class-1', 'class-2' ), $nav_menu_item->classes );
     }