Changeset 49631

Timestamp:

11/17/2020 04:46:30 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique.

Follow-up to [48374].

Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai.
Fixes #51256.

Location:

trunk/src/wp-admin

Files:

• includes/class-wp-plugins-list-table.php (modified) (1 diff)
• update-core.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -949 +949 @@
         $compatible_php = is_php_version_compatible( $requires_php );
         $class          = $is_active ? 'active' : 'inactive';
-        $checkbox_id    = 'checkbox_' . md5( $plugin_data['Name'] );
+        $checkbox_id    = 'checkbox_' . md5( $plugin_file );
 
         if ( $restrict_network_active || $restrict_network_only || in_array( $status, array( 'mustuse', 'dropins' ), true ) || ! $compatible_php ) {

trunk/src/wp-admin/update-core.php

@@ -546 +546 @@
         );
 
-        $checkbox_id = 'checkbox_' . md5( $plugin_data->Name );
+        $checkbox_id = 'checkbox_' . md5( $plugin_file );
         ?>
     <tr>