Changeset 49637

Timestamp:

11/17/2020 08:07:57 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Users: Use do_action_ref_array() for pre_get_users and pre_get_terms actions.

This brings some consistency with the other similar actions:

• pre_get_comments
• pre_get_networks
• pre_get_posts
• pre_get_sites
• pre_user_query

Follow-up to [29363] and [37572].

Props andy, adamsilverstein, hellofromTonya, desrosj, SergeyBiryukov.
Fixes #50961.

Location:

trunk/src/wp-includes

Files:

• class-wp-term-query.php (modified) (1 diff)
• class-wp-user-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-term-query.php

@@ -322 +322 @@
                  * @since 4.6.0
                  *
-                 * @param WP_Term_Query $this Current instance of WP_Term_Query.
+                 * @param WP_Term_Query $this Current instance of WP_Term_Query (passed by reference).
                  */
-                do_action( 'pre_get_terms', $this );
+                do_action_ref_array( 'pre_get_terms', array( &$this ) );
 
                 $taxonomies = (array) $args['taxonomy'];

trunk/src/wp-includes/class-wp-user-query.php

@@ -220 +220 @@
                  * Fires before the WP_User_Query has been parsed.
                  *
-                 * The passed WP_User_Query object contains the query variables, not
-                 * yet passed into SQL.
+                 * The passed WP_User_Query object contains the query variables,
+                 * not yet passed into SQL.
                  *
                  * @since 4.0.0
                  *
-                 * @param WP_User_Query $this The current WP_User_Query instance,
-                 *                            passed by reference.
+                 * @param WP_User_Query $this Current instance of WP_User_Query (passed by reference).
                  */
-                do_action( 'pre_get_users', $this );
+                do_action_ref_array( 'pre_get_users', array( &$this ) );
 
                 // Ensure that query vars are filled after 'pre_get_users'.
@@ -577 +576 @@
                  * @since 3.1.0
                  *
-                 * @param WP_User_Query $this The current WP_User_Query instance,
-                 *                            passed by reference.
+                 * @param WP_User_Query $this Current instance of WP_User_Query (passed by reference).
                  */
                 do_action_ref_array( 'pre_user_query', array( &$this ) );