Changeset 49683 for trunk/src/wp-admin/plugins.php

Timestamp:

11/23/2020 01:34:21 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Plugins: Check if _error_nonce is set before attempting to verify it.

This avoids a PHP notice on the Plugins screen when error query string is added to the URL.

Props wponlinesupport.
Fixes #43876.

File:

• trunk/src/wp-admin/plugins.php (modified) (1 diff)

trunk/src/wp-admin/plugins.php

@@ -642 +642 @@
     <?php
 
-    if ( ! isset( $_GET['main'] ) && ! isset( $_GET['charsout'] ) && wp_verify_nonce( $_GET['_error_nonce'], 'plugin-activation-error_' . $plugin ) ) {
+    if ( ! isset( $_GET['main'] ) && ! isset( $_GET['charsout'] )
+        && isset( $_GET['_error_nonce'] ) && wp_verify_nonce( $_GET['_error_nonce'], 'plugin-activation-error_' . $plugin )
+    ) {
         $iframe_url = add_query_arg(
             array(