Changeset 49696

Timestamp:

11/25/2020 04:09:41 AM (4 years ago)

Author:

peterwilsoncc

Message:

Build/Test Tools: Remove unused posts from AJAX test setUp().

Removes the creation of five posts from the AJAX test suite setUp() function, replacing it with a shared fixture only where required.

See #51802.

Location:

trunk/tests/phpunit

Files:

• includes/testcase-ajax.php (modified) (1 diff)
• tests/ajax/CustomizeMenus.php (modified) (2 diffs)

trunk/tests/phpunit/includes/testcase-ajax.php

@@ -150 +150 @@
         $this->_error_level = error_reporting();
         error_reporting( $this->_error_level & ~E_WARNING );
-
-        // Make some posts.
-        self::factory()->post->create_many( 5 );
     }
 

trunk/tests/phpunit/tests/ajax/CustomizeMenus.php

@@ -18 +18 @@
 
     /**
+     * Page IDs.
+     *
+     * @var int[]
+     */
+    public static $pages;
+
+    /**
+     * Post IDs.
+     *
+     * @var int[]
+     */
+    public static $posts;
+
+    /**
+     * Term IDs.
+     *
+     * @var int[]
+     */
+    public static $terms;
+
+    public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+        // Make some post objects.
+        self::$posts = $factory->post->create_many( 5 );
+        self::$pages = $factory->post->create_many( 5, array( 'post_type' => 'page' ) );
+
+        // Some terms too.
+        self::$terms = $factory->term->create_many( 5 );
+    }
+
+    /**
      * Set up the test fixture.
      */
@@ -342 +372 @@
         );
 
-        // Create some terms and pages.
-        self::factory()->term->create_many( 5 );
-        self::factory()->post->create_many( 5, array( 'post_type' => 'page' ) );
         $auto_draft_post = $this->wp_customize->nav_menus->insert_auto_draft_post(
             array(