Changeset 49703

Timestamp:

11/28/2020 12:44:44 PM (4 years ago)

Author:

azaozz

Message:

Quick/Bulk Edit: Fix undefined error when initializing UI Autocomplete 1.12.1 on non-existing element and then attempting to use the autocomplete instance.

Example: jQuery( '#nonexisting' ).autocomplete().autocomplete( 'instance' ).something.

Props _luigi, sabernhardt, donmhico, azaozz.
Fixes #51872.

Location:

trunk/src/js/_enqueues/admin

Files:

• inline-edit-post.js (modified) (1 diff)
• tags-suggest.js (modified) (2 diffs)

trunk/src/js/_enqueues/admin/inline-edit-post.js

@@ -329 +329 @@
                 textarea = $('textarea.tax_input_' + taxname, editRow),
                 comma = wp.i18n._x( ',', 'tag delimiter' ).trim();
+
+            // Ensure the textarea exists.
+            if ( ! textarea.length ) {
+                return;
+            }
 
             terms.find( 'img' ).replaceWith( function() { return this.alt; } );

trunk/src/js/_enqueues/admin/tags-suggest.js

@@ -38 +38 @@
         var last;
         var $element = $( this );
+
+        // Do not initialize if the element doesn't exist.
+        if ( ! $element.length ) {
+            return;
+        }
 
         options = options || {};
@@ -147 +152 @@
         $element.on( 'keydown', function() {
             $element.removeAttr( 'aria-activedescendant' );
-        } )
-        .autocomplete( options )
-        .autocomplete( 'instance' )._renderItem = function( ul, item ) {
-            return $( '<li role="option" id="wp-tags-autocomplete-' + item.id + '">' )
-                .text( item.name )
-                .appendTo( ul );
-        };
+        } );
+
+        $element.autocomplete( options );
+
+        // Ensure the autocomplete instance exists.
+        if ( $element.autocomplete( 'instance' ) ) {
+            $element.autocomplete( 'instance' )._renderItem = function( ul, item ) {
+                return $( '<li role="option" id="wp-tags-autocomplete-' + item.id + '">' )
+                    .text( item.name )
+                    .appendTo( ul );
+            };
+        }
 
         $element.attr( {