Changeset 49710

Timestamp:

11/30/2020 02:29:42 PM (4 years ago)

Author:

azaozz

Message:

Quick/Bulk Edit: Follow up to [49703]. Improve the logic a bit and always return this (the jQuery object) in wpTagsSuggest.

Fixes #51872.

File:

• trunk/src/js/_enqueues/admin/tags-suggest.js (modified) (3 diffs)

trunk/src/js/_enqueues/admin/tags-suggest.js

@@ -41 +41 @@
         // Do not initialize if the element doesn't exist.
         if ( ! $element.length ) {
-            return;
+            return this;
         }
 
@@ -157 +157 @@
 
         // Ensure the autocomplete instance exists.
-        if ( $element.autocomplete( 'instance' ) ) {
-            $element.autocomplete( 'instance' )._renderItem = function( ul, item ) {
-                return $( '<li role="option" id="wp-tags-autocomplete-' + item.id + '">' )
-                    .text( item.name )
-                    .appendTo( ul );
-            };
+        if ( ! $element.autocomplete( 'instance' ) ) {
+            return this;
         }
+
+        $element.autocomplete( 'instance' )._renderItem = function( ul, item ) {
+            return $( '<li role="option" id="wp-tags-autocomplete-' + item.id + '">' )
+                .text( item.name )
+                .appendTo( ul );
+        };
 
         $element.attr( {
@@ -179 +181 @@
                 $element.autocomplete( 'search' );
             }
-        } )
+        } );
+
         // Returns a jQuery object containing the menu element.
-        .autocomplete( 'widget' )
+        $element.autocomplete( 'widget' )
             .addClass( 'wp-tags-autocomplete' )
             .attr( 'role', 'listbox' )