Changeset 49712

Timestamp:

11/30/2020 04:51:15 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Display "You are using a development version" message on WordPress Updates screen for Beta or RC versions.

This ensures that the message is displayed when the WP_AUTO_UPDATE_CORE constant is set to beta or rc and the user is on a development version.

Follow-up to [49245], [49254], [49292], [49638], [49708].

Props afragen, audrasjb, azaozz, SergeyBiryukov.
Reviewed by azaozz, SergeyBiryukov.
Merges [49709] and [49668] to the 5.6 branch.
Fixes #51822.

Location:

branches/5.6

Files:

• . (modified) (1 prop)
• src/wp-admin/update-core.php (modified) (4 diffs)

branches/5.6/src/wp-admin/update-core.php

@@ -230 +230 @@
     global $required_php_version, $required_mysql_version;
 
-    $wp_version = get_bloginfo( 'version' );
-    $updates    = get_core_updates();
-
-    if ( isset( $updates[0] ) && isset( $updates[0]->version ) && version_compare( $updates[0]->version, $wp_version, '>' ) ) {
+    $updates = get_core_updates();
+
+    // Include an unmodified $wp_version.
+    require ABSPATH . WPINC . '/version.php';
+
+    $is_development_version = preg_match( '/alpha|beta|RC/', $wp_version );
+
+    if ( isset( $updates[0]->version ) && version_compare( $updates[0]->version, $wp_version, '>' ) ) {
         echo '<h2 class="response">';
         _e( 'An updated version of WordPress is available.' );
@@ -246 +250 @@
         );
         echo '</p></div>';
-    } elseif ( isset( $updates[0] ) && 'development' === $updates[0]->response ) {
+    } elseif ( $is_development_version ) {
         echo '<h2 class="response">' . __( 'You are using a development version of WordPress.' ) . '</h2>';
     } else {
@@ -259 +263 @@
     }
     echo '</ul>';
+
     // Don't show the maintenance mode notice when we are only showing a single re-install option.
     if ( $updates && ( count( $updates ) > 1 || 'latest' !== $updates[0]->response ) ) {
@@ -271 +276 @@
         ) . '</p>';
     }
+
     dismissed_updates();
 }