Changeset 49717

Timestamp:

12/01/2020 07:30:16 AM (4 years ago)

Author:

azaozz

Message:

Quick/Bulk Edit: Fix undefined error when initializing UI Autocomplete 1.12.1 on non-existing element and then attempting to use the autocomplete instance.

Example: jQuery( '#nonexisting' ).autocomplete().autocomplete( 'instance' ).something.

Props _luigi, sabernhardt, donmhico, azaozz.
Reviewed by SergeyBiryukov, azaozz.
Merges [49703] and [49710] to the 5.6 branch.
Fixes #51872.

Location:

branches/5.6

Files:

• . (modified) (1 prop)
• src/js/_enqueues/admin/inline-edit-post.js (modified) (1 diff)
• src/js/_enqueues/admin/tags-suggest.js (modified) (3 diffs)

branches/5.6/src/js/_enqueues/admin/inline-edit-post.js

@@ -329 +329 @@
                 textarea = $('textarea.tax_input_' + taxname, editRow),
                 comma = wp.i18n._x( ',', 'tag delimiter' ).trim();
+
+            // Ensure the textarea exists.
+            if ( ! textarea.length ) {
+                return;
+            }
 
             terms.find( 'img' ).replaceWith( function() { return this.alt; } );

branches/5.6/src/js/_enqueues/admin/tags-suggest.js

@@ -38 +38 @@
         var last;
         var $element = $( this );
+
+        // Do not initialize if the element doesn't exist.
+        if ( ! $element.length ) {
+            return this;
+        }
 
         options = options || {};
@@ -147 +152 @@
         $element.on( 'keydown', function() {
             $element.removeAttr( 'aria-activedescendant' );
-        } )
-        .autocomplete( options )
-        .autocomplete( 'instance' )._renderItem = function( ul, item ) {
+        } );
+
+        $element.autocomplete( options );
+
+        // Ensure the autocomplete instance exists.
+        if ( ! $element.autocomplete( 'instance' ) ) {
+            return this;
+        }
+
+        $element.autocomplete( 'instance' )._renderItem = function( ul, item ) {
             return $( '<li role="option" id="wp-tags-autocomplete-' + item.id + '">' )
                 .text( item.name )
@@ -169 +181 @@
                 $element.autocomplete( 'search' );
             }
-        } )
+        } );
+
         // Returns a jQuery object containing the menu element.
-        .autocomplete( 'widget' )
+        $element.autocomplete( 'widget' )
             .addClass( 'wp-tags-autocomplete' )
             .attr( 'role', 'listbox' )