Changeset 49752 for trunk/src/wp-admin/authorize-application.php

Timestamp:

12/04/2020 09:42:52 PM (4 years ago)

Author:

TimothyBlynJacobs

Message:

App Passwords: Prevent conflicts when Basic Auth is already used by the site.

Application Passwords uses Basic Authentication to transfer authentication details. If the site is already using Basic Auth, for instance to implement a private staging environment, then the REST API will treat this as an authentication attempt and would end up generating an error for any REST API request.

Now, Application Password authentication will only be attempted if Application Passwords is in use by a site. This is flagged by setting an option whenever an Application Password is created. An upgrade routine is added to set this option if any App Passwords already exist.

Lastly, creating an Application Password will be prevented if the site appears to already be using Basic Authentication.

Props chexwarrior, georgestephanis, adamsilverstein, helen, Clorith, marybaum, TimothyBlynJacobs.
Fixes #51939.

File:

• trunk/src/wp-admin/authorize-application.php (modified) (1 diff)

trunk/src/wp-admin/authorize-application.php

@@ -86 +86 @@
         __( 'The Authorize Application request is not allowed.' ) . ' ' . implode( ' ', $is_valid->get_error_messages() ),
         __( 'Cannot Authorize Application' )
+    );
+}
+
+if ( ! empty( $_SERVER['PHP_AUTH_USER'] ) || ! empty( $_SERVER['PHP_AUTH_PW'] ) ) {
+    wp_die(
+        __( 'Your website appears to use Basic Authentication, which is not currently compatible with Application Passwords.' ),
+        __( 'Cannot Authorize Application' ),
+        array(
+            'response'  => 501,
+            'link_text' => __( 'Go Back' ),
+            'link_url'  => $reject_url ? add_query_arg( 'error', 'disabled', $reject_url ) : admin_url(),
+        )
     );
 }