Changeset 49781

Timestamp:

12/09/2020 08:05:01 PM (3 years ago)

Author:

desrosj

Message:

Build/Test Tools: Disable GitHub Action workflow runs triggered on push for forks and mirrors.

In the current state, the workflows run regardless of the repository context. This results many needless workflow runs that waste resources.

Workflow runs for private repositories are not free (accounts have a finite allotment of minutes for private repositories). This becomes problematic in private repositories that also mirror the WordPress develop repository, as any workflow runs will draw from a user’s or organization’s allotted action minutes.

Without blanket disabling the workflow manually for all event triggers, or modifying the workflow files in the forked/mirrored repository, there is no way to tune when the workflows run.

This change introduces a conditional statement into all GitHub Action workflows that prevents them from running on forked/mirrored repositories that are not wordpress-develop, except when a pull request is being submitted to that repository.

The exception to this is the Welcome workflow that posts a helpful message to first time contributors to wordpress-develop. This message is specific to this repository, so should only run when a PR is submitted to that repository.

See #50401.

Location:

trunk/.github/workflows

Files:

• coding-standards.yml (modified) (2 diffs)
• end-to-end-tests.yml (modified) (1 diff)
• javascript-tests.yml (modified) (1 diff)
• php-compatibility.yml (modified) (1 diff)
• phpunit-tests.yml (modified) (1 diff)
• verify-npm-on-windows.yml (modified) (1 diff)
• welcome-new-contributors.yml (modified) (1 diff)

trunk/.github/workflows/coding-standards.yml

@@ -28 +28 @@
     name: PHP coding standards
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+
     steps:
       - name: Checkout repository
@@ -86 +88 @@
     name: JavaScript coding standards
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
     env:
       PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+
     steps:
       - name: Checkout repository

trunk/.github/workflows/end-to-end-tests.yml

@@ -35 +35 @@
     name: E2E Tests
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+
     steps:
       - name: Cancel previous runs of this workflow (pull requests only)

trunk/.github/workflows/javascript-tests.yml

@@ -24 +24 @@
     name: QUnit Tests
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+
     steps:
       - name: Cancel previous runs of this workflow (pull requests only)

trunk/.github/workflows/php-compatibility.yml

@@ -28 +28 @@
     name: Check PHP compatibility
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
 
     steps:

trunk/.github/workflows/phpunit-tests.yml

@@ -36 +36 @@
     name: Setup WordPress
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
 
     steps:

trunk/.github/workflows/verify-npm-on-windows.yml

@@ -25 +25 @@
     name: Tests NPM on Windows
     runs-on: windows-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
+
     steps:
       - name: Cancel previous runs of this workflow (pull requests only)

trunk/.github/workflows/welcome-new-contributors.yml

@@ -9 +9 @@
   post-welcome-message:
     runs-on: ubuntu-latest
+    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
 
     steps: