Changeset 49835

Timestamp:

12/18/2020 02:38:28 PM (4 years ago)

Author:

desrosj

Message:

Build/Test Tools: Run the Ajax test group for multisite.

This will help catch issues with Ajax related functionality on multisite.

A few tests have also been marked as skipWithMultisite() as they require network admin level capabilities when performing the same operations on a multisite install.

Props garrett-eclipse, netweb.
Fixes #46567.

Location:

trunk

Files:

• .github/workflows/phpunit-tests.yml (modified) (1 diff)
• Gruntfile.js (modified) (1 diff)
• tests/phpunit/tests/ajax/Attachments.php (modified) (1 diff)
• tests/phpunit/tests/ajax/DeletePlugin.php (modified) (1 diff)
• tests/phpunit/tests/ajax/ManageThemes.php (modified) (2 diffs)
• tests/phpunit/tests/ajax/UpdatePlugin.php (modified) (1 diff)

trunk/.github/workflows/phpunit-tests.yml

@@ -258 +258 @@
         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c tests/phpunit/multisite.xml
 
+      - name: Run AJAX tests as a multisite install
+        run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c tests/phpunit/multisite.xml --group ajax
+
       - name: Run ms-files tests as a multisite install
         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c tests/phpunit/multisite.xml --group ms-files

trunk/Gruntfile.js

@@ -673 +673 @@
                 cmd: 'phpunit',
                 args: ['--verbose', '-c', 'tests/phpunit/multisite.xml']
+            },
+            'ms-ajax': {
+                cmd: 'phpunit',
+                args: ['--verbose', '-c', 'tests/phpunit/multisite.xml', '--group', 'ajax']
             },
             'ms-files': {

trunk/tests/phpunit/tests/ajax/Attachments.php

@@ -66 +66 @@
      */
     public function test_wp_ajax_send_attachment_to_editor_should_return_a_link() {
+        $this->skipWithMultisite();
+
         // Become an administrator.
         $post    = $_POST;

trunk/tests/phpunit/tests/ajax/DeletePlugin.php

@@ -127 +127 @@
 
     public function test_delete_plugin() {
+        $this->skipWithMultisite();
         $this->_setRole( 'administrator' );
 

trunk/tests/phpunit/tests/ajax/ManageThemes.php

@@ -103 +103 @@
 
     public function test_update_theme() {
+        $this->skipWithMultisite();
         $this->_setRole( 'administrator' );
 
@@ -140 +141 @@
 
     function test_uppercase_theme_slug() {
+        $this->skipWithMultisite();
         $this->_setRole( 'administrator' );
 

trunk/tests/phpunit/tests/ajax/UpdatePlugin.php

@@ -131 +131 @@
 
     public function test_update_plugin() {
+        $this->skipWithMultisite();
         $this->_setRole( 'administrator' );