Changeset 49849

Timestamp:

12/21/2020 03:33:48 AM (4 years ago)

Author:

peterwilsoncc

Message:

Tests: Revert use of shared post fixture in comment template tests.

Removes code throwing a fatal in PHP 8.

Reverts [49848] from trunk.
See #51802.

File:

• trunk/tests/phpunit/tests/comment/template.php (modified) (5 diffs)

trunk/tests/phpunit/tests/comment/template.php

@@ -4 +4 @@
  */
 class Tests_Comment_Template extends WP_UnitTestCase {
-    /**
-     * Shared post ID.
-     *
-     * @var int
-     */
-    public static $post_id;
-
-    /**
-     * Set up shared fixtures.
-     *
-     * @param WP_UnitTest_Factory $factory Unit test factory.
-     */
-    function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
-        self::$post_id = self::factory()->post->create();
-    }
 
     function test_get_comments_number() {
-        $post_id = self::$post_id;
+        $post_id = self::factory()->post->create();
 
         $this->assertSame( 0, get_comments_number( 0 ) );
@@ -34 +19 @@
 
     function test_get_comments_number_without_arg() {
-        $post_id   = self::$post_id;
+        $post_id   = self::factory()->post->create();
         $permalink = get_permalink( $post_id );
         $this->go_to( $permalink );
@@ -50 +35 @@
      */
     function test_get_comments_number_text_with_post_id() {
-        $post_id = self::$post_id;
+        $post_id = $this->factory->post->create();
         $this->factory->comment->create_post_comments( $post_id, 6 );
 
@@ -69 +54 @@
      */
     function test_get_comments_number_text_declension_with_default_args() {
-        $post_id   = self::$post_id;
+        $post_id   = $this->factory->post->create();
         $permalink = get_permalink( $post_id );
         $this->go_to( $permalink );
@@ -92 +77 @@
      */
     function test_get_comments_number_text_declension_with_custom_args( $number, $input, $output ) {
-        $post_id   = self::$post_id;
+        $post_id   = $this->factory->post->create();
         $permalink = get_permalink( $post_id );